Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Documentation to Adapter Transforms #268

Merged
merged 13 commits into from
Dec 9, 2024

Conversation

eodole
Copy link
Collaborator

@eodole eodole commented Dec 4, 2024

Documentation added to:

  • concatonate.py: not sure if the options are all correct... can inference_conditions" be specified as the into string?
  • drop.py: this just seems like the opposite of keep, I'm not sure why we have both
  • elementwise_transform.py : not sure what this does other than be a parent class

Copy link
Contributor

@paul-buerkner paul-buerkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! please see my minor comments.

bayesflow/adapters/transforms/concatenate.py Outdated Show resolved Hide resolved
bayesflow/adapters/transforms/concatenate.py Outdated Show resolved Hide resolved
@paul-buerkner
Copy link
Contributor

Thank you! We have both keep and drop because it may be more efficient to use either of the two depending on the application. Doc for ElementwiseTransform looks good.

@eodole
Copy link
Collaborator Author

eodole commented Dec 6, 2024

I changed the documentation in

  • standardization.py: I wasn't sure about the mean/std explaination, I could also remove saying that people should specify their own mean/std because im not really sure what the use case would be
  • transform.py
  • one_hot.py

@paul-buerkner
Copy link
Contributor

I think this now looks good, thank you! Will merge now. About your standardize question: You are not sure what the use-case would be for the mean and SD inferred from data? Or the use case of a user-specified mean and SD?

@paul-buerkner paul-buerkner merged commit 554ed13 into bayesflow-org:dev Dec 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants