Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Documentation to Adapter Transforms #267

Closed
wants to merge 5 commits into from
Closed

Added Documentation to Adapter Transforms #267

wants to merge 5 commits into from

Conversation

eodole
Copy link
Collaborator

@eodole eodole commented Dec 4, 2024

Documentation added to:

  • concatonate.py: not sure if the options are all correct... can "inference_conditions" be specified as the into string?
  • drop.py: this just seems like the opposite of keep, I'm not sure why we have both
  • elementwise_transform.py : not sure what this does other than be a parent class

@paul-buerkner
Copy link
Contributor

Thank you! Can you please provide more information names for your PR?

@eodole eodole changed the title Dev Added Documentation to Adapter Transforms Dec 4, 2024
@eodole eodole closed this Dec 4, 2024
@paul-buerkner
Copy link
Contributor

You can just rename your PR. No need to close this one.

@eodole
Copy link
Collaborator Author

eodole commented Dec 4, 2024

I realized that concatonate.py didnt get resolved I have to fix it then push another commit

@paul-buerkner
Copy link
Contributor

You can always commit more commits to a PR. But I am not sure I understand the issue correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eodole @paul-buerkner