Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF Clean-Up #186

Merged
merged 1 commit into from
Sep 24, 2024
Merged

CIF Clean-Up #186

merged 1 commit into from
Sep 24, 2024

Conversation

LarsKue
Copy link
Contributor

@LarsKue LarsKue commented Sep 18, 2024

  • Add type hints
  • Use different defaults
  • Fix compute_metrics signature
  • Other minor changes

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.04%. Comparing base (fbda19c) to head (22c1768).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
bayesflow/networks/cif/conditional_gaussian.py 37.50% 10 Missing ⚠️
bayesflow/networks/cif/cif.py 60.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #186      +/-   ##
==========================================
- Coverage   54.04%   54.04%   -0.01%     
==========================================
  Files         140      140              
  Lines        3225     3229       +4     
==========================================
+ Hits         1743     1745       +2     
- Misses       1482     1484       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 👍🏻

@LarsKue LarsKue merged commit 2d154b4 into dev Sep 24, 2024
13 checks passed
@LarsKue LarsKue deleted the clean-cif branch September 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants