update-amd-tdp #13157
Open
update-amd-tdp #13157
+95
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikhailzrick
force-pushed
the
update-amd-tdp
branch
2 times, most recently
from
e780702 to
e7267c7
Compare
Mikhailzrick
force-pushed
the
update-amd-tdp
branch
2 times, most recently
from
e92d6fd to
e0cfa5c
Compare
bryanforbes
reviewed
Jan 16, 2025
|
@bryanforbes thanks for reviewing, I’ll fix some of the obvious stuff I missed in the first draft of changes. The issue with a system or game tdp value but not global I didn’t even think of, I’ll address that as well. I’ll try to find time this coming weekend to work on it. |
Mikhailzrick
force-pushed
the
update-amd-tdp
branch
from
e0cfa5c to
cf64868
Compare
|
Updated PR to resolve prior issues and clean up some. Also changed the resume script to better handle situations where if a user has a per system/game tdp value and suspends while a game is running it will save tdp, suspend, resume, and the revert back to saved tdp value. This is needed since ryzenadj changes do not persist after suspend. |
bryanforbes
requested changes
Mar 2, 2025
Mikhailzrick
force-pushed
the
update-amd-tdp
branch
from
cf64868 to
0328d07
Compare
|
Made recommended changes by @bryanforbes and moved PR out of draft |
Update es_features.yml Update tdp_hooks.sh Update batocera-amd-tdp Update batocera-amd-tdp amd-tdp-update update Update 99resume_tdp
Mikhailzrick
force-pushed
the
update-amd-tdp
branch
from
0328d07 to
7b572b7
Compare
bryanforbes
approved these changes
Mar 20, 2025
|
@dmanlfc would you mind reviewing this? I think it's ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to change behavior of amd TDP scripts to account for new slider which when set to "auto" will not have an entry in batocera.conf and should allow system bios to determine tdp values.
Improved resume script which now saves the current tdp to a temp file if it does not equal system.cpu.tdp, which is then used to revert back to after resume. This should handle situations where a user suspends while a game is running ensuring per system/game setting is kept.
Refactor code for better readability.
stapm/fast/slow set to same tdp value.
Also removed hard coded temp limit so bios can handle it. May be beneficial to include a separate temp limit slider which could be used in the future.