Skip to content

Commit

Permalink
- Logs a warning message when strong consistency is enabled and AAE is
Browse files Browse the repository at this point in the history
  disabled.  (defect #959)
  • Loading branch information
John Burwell committed Jun 10, 2014
1 parent bda3310 commit ac98698
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/riak_kv_ensembles.erl
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ maybe_bootstrap_ensembles() ->
false ->
ok;
true ->
_ = maybe_aae_configuration_valid(app_helper:get_env(riak_kv, anti_entropy)),
{ok, Ring, CHBin} = riak_core_ring_manager:get_raw_ring_chashbin(),
IsClaimant = (riak_core_ring:claimant(Ring) == node()),
IsReady = riak_core_ring:ring_ready(Ring),
Expand All @@ -160,6 +161,13 @@ maybe_bootstrap_ensembles() ->
end
end.

-spec maybe_aae_configuration_valid(atom() | any()) -> boolean().
maybe_aae_configuration_valid(on) ->
true;
maybe_aae_configuration_valid(_) ->
lager:warning("Strong consistency has been enabled without AAE -- all consistent operations will timeout until AAE is enabled."),
false.

bootstrap_preflists(Ring, CHBin) ->
%% TODO: We have no notion of deleting ensembles. Nor do we check if
%% we should. Thus, ring resizing (shrinking) is broken.
Expand Down

11 comments on commit ac98698

@kellymclaughlin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/riak_kv/bugfix/jsb/start-ensemble-without-aae = ac98698 into borshop-integration-978-bugfix/jsb/start-ensemble-without-aae

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from kellymclaughlin
at ac98698

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/riak_kv/bugfix/jsb/start-ensemble-without-aae = ac98698 merged ok, testing candidate = fe31438

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellymclaughlin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop: retry

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/riak_kv/bugfix/jsb/start-ensemble-without-aae = ac98698 merged ok, testing candidate = e351a64

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/riak_kv/bugfix/jsb/start-ensemble-without-aae = ac98698 into borshop-integration-978-bugfix/jsb/start-ensemble-without-aae

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from kellymclaughlin
at ac98698

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding develop to borshop-integration-978-bugfix/jsb/start-ensemble-without-aae = e351a64

Please sign in to comment.