Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

130 add fix attribute output type #131

Merged
merged 4 commits into from
Mar 7, 2025
Merged

130 add fix attribute output type #131

merged 4 commits into from
Mar 7, 2025

Conversation

c-w-feldmann
Copy link
Collaborator

@c-w-feldmann c-w-feldmann commented Mar 7, 2025 •
edited
Loading

Solves #130
ToDos:

  • Add output_type to ChempropNeuralFP
  • Make output_type of MolToMorganFP depend on the attribute counted
  • Add unit tests

@c-w-feldmann c-w-feldmann self-assigned this Mar 7, 2025
@c-w-feldmann c-w-feldmann linked an issue Mar 7, 2025 that may be closed by this pull request
Add fix attribute output_type #130
Closed
@c-w-feldmann c-w-feldmann merged commit 75eb7e4 into main Mar 7, 2025
17 checks passed
@c-w-feldmann c-w-feldmann deleted the 130-add-fix-attribute-output_type branch March 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JochenSiegWork JochenSiegWork JochenSiegWork approved these changes

Assignees

@c-w-feldmann c-w-feldmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fix attribute output_type
2 participants
@c-w-feldmann @JochenSiegWork