Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove raise_nones #129

Conversation

c-w-feldmann
Copy link
Collaborator

@c-w-feldmann c-w-feldmann commented Feb 26, 2025

The object _MolPipeline has a property called raise_nones. This is legacy property and can be reomved. See related issue

@c-w-feldmann c-w-feldmann added the type: maintenance Improvement of code or keeping the code up to date label Feb 26, 2025
@c-w-feldmann c-w-feldmann linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please explain why you made these changes

@c-w-feldmann
Copy link
Collaborator Author

Looks good but please explain why you made these changes

Done

@c-w-feldmann c-w-feldmann merged commit 37a8029 into main Feb 27, 2025
17 checks passed
@c-w-feldmann c-w-feldmann deleted the 128-remove-deprecated-property-raise_nones-from-_molpipeline branch February 27, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Improvement of code or keeping the code up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated property: raise_nones from _MolPipeline
2 participants