feat: resend webhooks #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhe4rt
reviewed
Oct 7, 2025
Comment on lines
21
to
27
| foreach ($headers as $header) { | ||
|
|
||
| if ($header['name'] == config('filament-better-mails.mails.headers.key')) { | ||
| $mailUuid = $header['value']; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| foreach ($headers as $header) { | |
| if ($header['name'] == config('filament-better-mails.mails.headers.key')) { | |
| $mailUuid = $header['value']; | |
| break; | |
| } | |
| } | |
| foreach ($headers as $header) { | |
| if ($this->validateHeaderKey($header['name']) { | |
| $mailUuid = $header['value']; | |
| break; | |
| } | |
| } |
danielhe4rt
reviewed
Oct 7, 2025
|
|
||
| namespace Basement\BetterMails\Core\Contracts; | ||
|
|
||
| interface BetterDTOContract |
There was a problem hiding this comment.
Suggested change
| interface BetterDTOContract | |
| interface BetterMailDTOContract |
danielhe4rt
reviewed
Oct 7, 2025
| $mailUuid = $dto['data']['headers'][0]['value'] ?? $dto['mailUuid']; | ||
|
|
||
| return new self( | ||
| mailUuid: $mailUuid, |
There was a problem hiding this comment.
use Ramsey\Uuid\Uuid::fromString();
… events instead of updating them
| use Illuminate\Foundation\Events\Dispatchable; | ||
| use Illuminate\Queue\SerializesModels; | ||
|
|
||
| final class ResendEmailComplainedEvent implements COmplainedEventContract |
There was a problem hiding this comment.
ComplainedEventContract
danielhe4rt
approved these changes
Oct 13, 2025
|
|
||
| foreach ($headers as $header) { | ||
|
|
||
| if ($header[$headerKey] == config('filament-better-mails.mails.headers.key')) { |
There was a problem hiding this comment.
Suggested change
| if ($header[$headerKey] == config('filament-better-mails.mails.headers.key')) { | |
| if ($header[$headerKey] == strtolower(config('filament-better-mails.mails.headers.key'))) { |
would be cool to parse the key from the request and ours to lowercase.
i had a really bad time when i forgot this, so i assume that would be a better thing.
…e to VerifyHeaderWebhookSignature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in progress, just publishing to show improvements