Enable h2c support

[kevinmcconnell]

No description provided.

[skulos]

Any updates on this PR? For GCP we needed H2C so I forked this repo and added H2C similar to this PR. Would like to use the gem instead of dragging my repo in and compiling it to run with the Rails app on GCP.

[skulos]

@kevinmcconnell are there any updates on this PR?

[skulos]

Are there any updates on this PR?
@kevinmcconnell @3v0k4

[3v0k4]

Hey @skulos, you'll need to wait for Kevin on this one.

Sorry, I cannot help more 🙂

[skulos]

@kevinmcconnell any updates on this PR?

[kevinmcconnell]

Hi @skulos, sorry for the slow response on this one. And thanks for the nudges :)

One possible side effect of this is the fact that the entire request will be read into memory during an h2c upgrade. We have a MAX_REQUEST_BODY that can be used to guard against maliciously-large requests, but this does mean that supporting h2c (at least with this implementation) makes setting a limit more necessary. And it's hard to set a good default on that, since it's so application-specific.

So I'm thinking we could initially ship this behind an opt-in flag, like H2C_ENABLED. People who need it can enable it, along with setting an appropriate request size limit. People who don't need it (which is probably most folks) won't be affected. What do you think?