Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch directories and volume examples in accessories.md #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakeprem
Copy link

This better matches how these are being used with Docker. The directories setting is passing in a directory from a path, while the volumes setting will create a docker volume with the given name.


The Volumes section also states:
"Any other volumes to mount, in addition to the files and directories. They are not created or copied before mounting:"

I wonder if this should also be updated to clarify that it will create the Docker volume if it doesn't exist.

Tat's the behavior I observed anyway. I switched from a directory mount to a volume for my database accessory's data and the Docker volume was created automatically.

This better matches how these are being used with Docker.
The directories setting is passing in a directory from a path,
while the volumes setting will create a docker volume with
the given name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant