Skip to content

Refactor system comment classes #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jzimdars merged 4 commits into from
Dec 22, 2025
Merged

Refactor system comment classes #2230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc6b5cb
Use hash for conditional class
nqst Dec 19, 2025
e52eba9
Rename `.comment--system` to `.system-comment`
nqst Dec 19, 2025
5657ee0
Remove extra space
nqst Dec 19, 2025
5716303
Rename
jzimdars Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/assets/stylesheets/comments.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
padding: var(--comment-padding-block) 0 0;
}

.comment--system & {
.comment-by-system & {
--comment-padding-block: var(--block-space-half);

text-align: center;
Expand Down Expand Up @@ -72,7 +72,7 @@
var(--stripe-color) 1px 10px);
padding-inline: var(--comment-padding-inline);

.comments--system-expanded .comment--system & {
.comments--system-expanded .comment-by-system & {
--stripe-color: color-mix(in srgb, var(--card-color) 10%, var(--color-canvas));
}

Expand Down Expand Up @@ -144,7 +144,7 @@
position: absolute;
}

.comment--system {
.comment-by-system {
display: none;
transition: var(--dialog-duration) allow-discrete;
transition-property: display;
Expand All @@ -155,7 +155,7 @@
}

/* Show the last system comment */
:nth-last-child(1 of .comment--system) {
:nth-last-child(1 of .comment-by-system) {
display: contents;

.comment__history {
Expand All @@ -164,7 +164,7 @@
}

/* Hide the "Show history" button if there's only one system comment */
:nth-child(1 of .comment--system) {
:nth-child(1 of .comment-by-system) {
.comment__history {
display: none;
}
Expand Down
4 changes: 2 additions & 2 deletions app/views/cards/comments/_comment.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<% cache comment do %>
<%# Helper Dependency Updated: avatar_image_tag 2025-12-15 %>
<%= turbo_frame_tag comment, :container, class: ["comment--system": comment.creator.system?] do %>
<%= turbo_frame_tag comment, :container, class: { "comment-by-system": comment.creator.system? } do %>
<%# Cache bump 2025-12-14: action text attachment rendering changed for lightbox -%>
<div id="<%= dom_id(comment) %>" data-creator-id="<%= comment.creator_id %>" class="comment align-start full-width">
<div id="<%= dom_id(comment) %>" data-creator-id="<%= comment.creator_id %>" class="comment align-start full-width">
<figure class="comment__avatar flex-item-no-shrink" aria-hidden="true">
<%= avatar_tag comment.creator, hidden_for_screen_reader: true %>
</figure>
Expand Down