feat: add verification service for flashblocks with metrics tracking for block reorgs #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
block-reorg-verification
branch
from
9fcead6 to
a9731b6
Compare
jowparks
force-pushed
the
block-reorg-verification
branch
2 times, most recently
from
36ca8da to
48232cf
Compare
jowparks
force-pushed
the
block-reorg-verification
branch
from
48232cf to
d2cf877
Compare
jowparks
force-pushed
the
block-reorg-verification
branch
from
d2cf877 to
b8d109a
Compare
| let chain_spec = builder.config().chain.clone(); | ||
| let handle = builder | ||
| .with_types_and_provider::<OpNode, BlockchainProvider<_>>() | ||
| .with_components(op_node.components()) | ||
| .with_add_ons(op_node.add_ons()) | ||
| .on_component_initialized(move |_ctx| Ok(())) | ||
| .install_exex("flashblocks-verification", async move |ctx| { |
There was a problem hiding this comment.
wondering if this should be optional and only enabled with a flag? wdyt?
| let verification_service = VerificationService::new(cache); | ||
| while let Some(notification) = ctx.notifications.try_next().await? { | ||
| match ¬ification { | ||
| ExExNotification::ChainCommitted { new } => { |
There was a problem hiding this comment.
Does this mean it gets triggered during historical syncing as well?
I think we probably only want it to start verifying when live syncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flashblocks Verification Service