fix(linker): fix broken linker symbols #257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielRep
requested review from
DavidMCerdeira,
josecm and
miguelafsilva5
as code owners
|
Tested on Renesas RH850/U2A16. Working ✅ |
Thanks @malejo97 for testing!! |
This commit addresses issues introduced on linker symbols when MEM_NON_UNIFIED and .datanocopy were added. - Add _data_(vma/lma)_end symbol to get the address of the data end address used during the data copy routine of non-unified platforms - Move _image_load_end to the original location right before the vm_images, allowing .datanocopy to be correctly mapped in bao's first continuous region - Force _dmem_phys_beg calculation to be related to the type of memory protection (mpu/mmu) of the platform and not the memory type (unified/non-unified) Signed-off-by: Daniel Oliveira <[email protected]>
danielRep
force-pushed
the
fix/linker-symbols
branch
from
c51953a to
ac51124
Compare
|
@josecm @miguelafsilva5 This has been tested across plats and archs on bao-demos (baremetal). No issue has detected. Regarding |
miguelafsilva5
approved these changes
Oct 8, 2025
|
Just tested qemu-riscv32-virt using the toolchain available here https://github.com/bao-project/bao-riscv-toolchain/releases/tag/gc891d8dc23e |
Thanks @miguelafsilva5 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues introduced on linker symbols when
MEM_NON_UNIFIEDand.datanocopywere added._data_(vma/lma)_endsymbol to get the address of the data end address used during the data copy routine of non-unified platforms_image_load_endto the original location right before the vm_images, allowing.datanocopyto be correctly mapped in bao's first continuous region_dmem_phys_begcalculation to be related to the type of memory protection (mpu/mmu) of the platform and not the memory type (unified/non-unified)Before accepting this PR, take notice on the below table, were I will be testing these changes on the below platforms that exercise those symbols for different architectures, memory protection mechanisms, and memory infrastructures to ensure the correctness of the new linkerscript file.