Update Google Pay #22
Conversation
android/src/main/java/tech/bam/RNBraintreeDropIn/RNBraintreeDropInModule.java
Outdated
Show resolved
Hide resolved
| dependencies { | ||
| implementation 'com.braintreepayments.api:drop-in:4.+' | ||
| implementation 'com.facebook.react:react-native:+' | ||
| // Braintree dependencies |
There was a problem hiding this comment.
It would be better for users to make this a configuration step for using the library
Not everybody wants to have this in their code
See example of 3D Secure https://github.com/bamlab/react-native-braintree-payments-drop-in#3d-secure
There was a problem hiding this comment.
These library must be in library's gradle. If not, there will be an error like below
| GooglePaymentRequest googlePaymentRequest = new GooglePaymentRequest() | ||
| .transactionInfo(TransactionInfo.newBuilder() | ||
| .setTotalPrice(String.valueOf(googlePayOptions.getDouble("amount"))) | ||
| .setTotalPriceStatus(WalletConstants.TOTAL_PRICE_STATUS_FINAL) |
There was a problem hiding this comment.
Shouldn't that be configurable ?
There was a problem hiding this comment.
Could you explain more detail please?
There was a problem hiding this comment.
This can be made in a follow-up PR, but apparently total price status can be changed to estimated or not known. This should be ideally an option in this bridge.
| if (googlePayOptions.hasKey("merchantName")) { | ||
| googlePaymentRequest.googleMerchantName(googlePayOptions.getString("merchantName")); | ||
| } | ||
| googlePaymentRequest.googleMerchantName("Simi"); |
There was a problem hiding this comment.
I have removed line 77. Is that right?
| googlePaymentRequest.googleMerchantName("Simi"); | ||
| dropInRequest.googlePaymentRequest(googlePaymentRequest); | ||
| } else { | ||
| dropInRequest.disableGooglePayment(); |
There was a problem hiding this comment.
Is this line really necessary, and if yes does it work when you remove the gradle deps that you added earlier?
There was a problem hiding this comment.
This line is required to disable Google pay when developer doesn't pass "googlePay" parameter
|
I'll test this as soon as possible and come back to you, thanks for taking into account my review :) |
Minishlink
left a comment
Minishlink
left a comment
There was a problem hiding this comment.
Can you add the configuration and usage sections of Google Pay in the README please?
| implementation 'com.braintreepayments.api:drop-in:4.+' | ||
| implementation 'com.facebook.react:react-native:+' | ||
| // Braintree dependencies | ||
| implementation 'com.braintreepayments.api:braintree:3.7.0' |
There was a problem hiding this comment.
After testing, you don't need to add this dependancy (it might be a sub deps of the drop-in)
There was a problem hiding this comment.
Could you show me your testing without these dependencies? I still haven't figured out the way to do it
| implementation 'com.facebook.react:react-native:+' | ||
| // Braintree dependencies | ||
| implementation 'com.braintreepayments.api:braintree:3.7.0' | ||
| implementation 'com.braintreepayments.api:google-payment:3.2.0' |
There was a problem hiding this comment.
After testing, you don't need to add this dependancy (it might be a sub deps of the drop-in)
| implementation 'com.braintreepayments.api:google-payment:3.2.0' | ||
|
|
||
| // Google dependencies | ||
| implementation 'com.google.android.gms:play-services-wallet:16.0.1' |
| @@ -0,0 +1,9 @@ | |||
| arguments= | |||
| auto.sync=false | |||
| gradle.user.home= | |||
There was a problem hiding this comment.
Sorry, I meant the whole file, it should be ignored by the gitignore
There was a problem hiding this comment.
I have just remove this file and .settings already in gitignore
2 participants
Hi, please review my PR. We are working with Braintree and your library is great with credit card and Paypal option. However, we need Google Pay works as well.