Skip to content

Implement HTTP/2 IDLE based eviction #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Implement HTTP/2 IDLE based eviction #2277

merged 13 commits into from
Feb 19, 2025

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Jan 21, 2025

Purpose

Fixes: ballerina-platform/ballerina-library#7309

Before this implementation: https://github.com/TharmiganK/ballerina-http-performance-tests/actions/runs/13367157572
After this implementation: https://github.com/TharmiganK/ballerina-http-performance-tests/actions/runs/13367166344

Examples

Refer to the attached issue

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (252293a) to head (8ece332).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tractimpl/sender/http2/Http2ConnectionManager.java 89.18% 2 Missing and 2 partials ⚠️

❌ Your project check has failed because the head coverage (79.94%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2277      +/-   ##
============================================
+ Coverage     79.91%   79.94%   +0.02%     
  Complexity      678      678              
============================================
  Files           418      418              
  Lines         23124    23157      +33     
  Branches       3753     3757       +4     
============================================
+ Hits          18480    18513      +33     
  Misses         3512     3512              
  Partials       1132     1132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK marked this pull request as ready for review January 23, 2025 04:51
@TharmiganK
Copy link
Contributor Author

Closing this for now, until we do a perf test with the changes

@TharmiganK TharmiganK closed this Feb 11, 2025
@TharmiganK TharmiganK reopened this Feb 17, 2025
@TharmiganK TharmiganK merged commit 8570780 into master Feb 19, 2025
6 checks passed
@TharmiganK TharmiganK deleted the idle-eviction branch February 19, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The IDLE based eviction is not supported for HTTP/2 connections
2 participants