Merge pull request #2267 from warunalakshitha/java21_perf

Remove unnecessary virtual thread creation
ballerina-platform · Jan 9, 2025 · 92e1281 · 92e1281
2 parents b58e52d + ea84aee
commit 92e1281
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 31 deletions.
diff --git a/ballerina/Dependencies.toml b/ballerina/Dependencies.toml
@@ -5,7 +5,7 @@
 
 [ballerina]
 dependencies-toml-version = "2"
-distribution-version = "2201.11.0-20241218-101200-109f6cc7"
+distribution-version = "2201.11.0-20250109-162500-c85851f4"
 
 [[package]]
 org = "ballerina"

diff --git a/gradle.properties b/gradle.properties
@@ -1,7 +1,7 @@
 org.gradle.caching=true
 group=io.ballerina.stdlib
 version=2.13.0-SNAPSHOT
-ballerinaLangVersion=2201.11.0-20241218-101200-109f6cc7
+ballerinaLangVersion=2201.11.0-20250109-162500-c85851f4
 ballerinaTomlParserVersion=1.2.2
 commonsLang3Version=3.12.0
 nettyVersion=4.1.115.Final

diff --git a/native/src/main/java/io/ballerina/stdlib/http/api/HttpCallableUnitCallback.java b/native/src/main/java/io/ballerina/stdlib/http/api/HttpCallableUnitCallback.java
@@ -115,15 +115,13 @@ private void returnErrorResponse(BError error) {
     }
 
     public void invokeBalMethod(Object[] paramFeed, String methodName) {
-        Thread.startVirtualThread(() -> {
-            try {
-                StrandMetadata metaData = new StrandMetadata(false, null);
-                runtime.callMethod(caller, methodName, metaData, paramFeed);
-                stopObserverContext();
-            } catch (BError error) {
-                sendFailureResponse(error);
-            }
-        });
+        try {
+            StrandMetadata metaData = new StrandMetadata(true, null);
+            runtime.callMethod(caller, methodName, metaData, paramFeed);
+            stopObserverContext();
+        } catch (BError error) {
+            sendFailureResponse(error);
+        }
     }
 
     public void stopObserverContext() {

diff --git a/native/src/main/java/io/ballerina/stdlib/http/api/HttpRequestInterceptorUnitCallback.java b/native/src/main/java/io/ballerina/stdlib/http/api/HttpRequestInterceptorUnitCallback.java
@@ -169,15 +169,13 @@ private void returnResponse(Object result) {
     }
 
     public void invokeBalMethod(Object[] paramFeed, String methodName) {
-        Thread.startVirtualThread(() -> {
-            try {
-                StrandMetadata metaData = new StrandMetadata(false, null);
-                runtime.callMethod(caller, methodName, metaData, paramFeed);
-            } catch (BError error) {
-                cleanupRequestMessage();
-                HttpUtil.handleFailure(requestMessage, error);
-            }
-        });
+        try {
+            StrandMetadata metaData = new StrandMetadata(true, null);
+            runtime.callMethod(caller, methodName, metaData, paramFeed);
+        } catch (BError error) {
+            cleanupRequestMessage();
+            HttpUtil.handleFailure(requestMessage, error);
+        }
     }
 
     private int getRequestInterceptorId() {

diff --git a/native/src/main/java/io/ballerina/stdlib/http/api/HttpResponseInterceptorUnitCallback.java b/native/src/main/java/io/ballerina/stdlib/http/api/HttpResponseInterceptorUnitCallback.java
@@ -154,17 +154,16 @@ private void returnResponse(Object result) {
 
     @Override
     public void invokeBalMethod(Object[] paramFeed, String methodName) {
-        Thread.startVirtualThread(() -> {
-            try {
-                StrandMetadata metaData = new StrandMetadata(true, null);
-                this.getRuntime().callMethod(caller, methodName, metaData, paramFeed);
-                stopObserverContext();
-                dataContext.notifyOutboundResponseStatus(null);
-            } catch (BError error) {
-                dataContext.notifyOutboundResponseStatus(null);
-                sendFailureResponse(error);
-            }
-        });
+
+        try {
+            StrandMetadata metaData = new StrandMetadata(true, null);
+            this.getRuntime().callMethod(caller, methodName, metaData, paramFeed);
+            stopObserverContext();
+            dataContext.notifyOutboundResponseStatus(null);
+        } catch (BError error) {
+            dataContext.notifyOutboundResponseStatus(null);
+            sendFailureResponse(error);
+        }
     }
 
     private int getResponseInterceptorId() {