-
Notifications
You must be signed in to change notification settings - Fork 3
Add lineage processors #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philipp94831
wants to merge
8
commits into
master
Choose a base branch
from
feature/lineage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a9ef656
Add lineage processors
philipp94831 c0845eb
Clean up
philipp94831 acc6c2c
Clean up
philipp94831 f992b62
Add docs
philipp94831 58e7569
Add docs
philipp94831 2ab7c55
Add docs
philipp94831 f81fdba
Merge remote-tracking branch 'origin/master' into feature/lineage
philipp94831 97ace91
Update tests
philipp94831 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
streams-bootstrap-core/src/main/java/com/bakdata/kafka/streams/kstream/LineageHeaders.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* MIT License | ||
* | ||
* Copyright (c) 2025 bakdata | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
package com.bakdata.kafka.streams.kstream; | ||
|
||
import java.nio.charset.StandardCharsets; | ||
import lombok.AccessLevel; | ||
import lombok.Getter; | ||
import lombok.NonNull; | ||
import lombok.RequiredArgsConstructor; | ||
import lombok.experimental.Accessors; | ||
import org.apache.kafka.common.header.Headers; | ||
|
||
/** | ||
* Configure headers for data lineage of Kafka messages | ||
*/ | ||
@RequiredArgsConstructor(access = AccessLevel.PACKAGE) | ||
public class LineageHeaders { | ||
private static final String LINEAGE_PREFIX = "lineage."; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should use a namespace that contains streams-bootstrap or make the header names configurable |
||
/** | ||
* Header indicating the topic the record was read from. | ||
*/ | ||
public static final String TOPIC_HEADER = LINEAGE_PREFIX + "topic"; | ||
/** | ||
* Header indicating the partition the record was read from. | ||
*/ | ||
public static final String PARTITION_HEADER = LINEAGE_PREFIX + "partition"; | ||
/** | ||
* Header indicating the offset the record was read from. | ||
*/ | ||
public static final String OFFSET_HEADER = LINEAGE_PREFIX + "offset"; | ||
|
||
@Getter(AccessLevel.PACKAGE) | ||
@Accessors(fluent = true) | ||
private final @NonNull Headers headers; | ||
|
||
LineageHeaders addTopicHeader(final String topic) { | ||
if (topic == null) { | ||
return this; | ||
} | ||
return new LineageHeaders(this.headers.add(TOPIC_HEADER, topic.getBytes(StandardCharsets.UTF_8))); | ||
} | ||
|
||
LineageHeaders addPartitionHeader(final int partition) { | ||
if (partition < 0) { | ||
return this; | ||
} | ||
//TODO serialize more compact as int? But then UI tools usually can't handle it | ||
return new LineageHeaders( | ||
this.headers.add(PARTITION_HEADER, Integer.toString(partition).getBytes(StandardCharsets.UTF_8))); | ||
} | ||
|
||
LineageHeaders addOffsetHeader(final long offset) { | ||
if (offset < 0) { | ||
return this; | ||
} | ||
//TODO serialize more compact as long? But then UI tools usually can't handle it | ||
return new LineageHeaders( | ||
this.headers.add(OFFSET_HEADER, Long.toString(offset).getBytes(StandardCharsets.UTF_8))); | ||
} | ||
} |
59 changes: 59 additions & 0 deletions
59
streams-bootstrap-core/src/main/java/com/bakdata/kafka/streams/kstream/LineageProcessor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* MIT License | ||
* | ||
* Copyright (c) 2025 bakdata | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
package com.bakdata.kafka.streams.kstream; | ||
|
||
import java.util.Optional; | ||
import org.apache.kafka.common.header.Headers; | ||
import org.apache.kafka.common.header.internals.RecordHeaders; | ||
import org.apache.kafka.streams.processor.api.FixedKeyProcessor; | ||
import org.apache.kafka.streams.processor.api.FixedKeyProcessorContext; | ||
import org.apache.kafka.streams.processor.api.FixedKeyRecord; | ||
import org.apache.kafka.streams.processor.api.RecordMetadata; | ||
|
||
class LineageProcessor<K, V> implements FixedKeyProcessor<K, V, V> { | ||
private FixedKeyProcessorContext<K, V> context; | ||
|
||
private static Headers addHeaders(final Headers headers, final RecordMetadata metadata) { | ||
return new LineageHeaders(new RecordHeaders(headers)) | ||
.addTopicHeader(metadata.topic()) | ||
.addPartitionHeader(metadata.partition()) | ||
.addOffsetHeader(metadata.offset()) | ||
.headers(); | ||
} | ||
|
||
@Override | ||
public void init(final FixedKeyProcessorContext<K, V> context) { | ||
this.context = context; | ||
} | ||
|
||
@Override | ||
public void process(final FixedKeyRecord<K, V> rekord) { | ||
final Optional<RecordMetadata> metadata = this.context.recordMetadata(); | ||
final Headers headers = rekord.headers(); | ||
final Headers newHeaders = metadata.map(m -> addHeaders(headers, m)) | ||
.orElse(headers); | ||
this.context.forward(rekord.withHeaders(newHeaders)); | ||
} | ||
} |
52 changes: 52 additions & 0 deletions
52
...ms-bootstrap-core/src/main/java/com/bakdata/kafka/streams/kstream/LineageTransformer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* MIT License | ||
* | ||
* Copyright (c) 2025 bakdata | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
package com.bakdata.kafka.streams.kstream; | ||
|
||
import org.apache.kafka.streams.kstream.ValueTransformerWithKey; | ||
import org.apache.kafka.streams.processor.ProcessorContext; | ||
|
||
class LineageTransformer<K, V> implements ValueTransformerWithKey<K, V, V> { | ||
|
||
private ProcessorContext context; | ||
|
||
@Override | ||
public void init(final ProcessorContext context) { | ||
this.context = context; | ||
} | ||
|
||
@Override | ||
public V transform(final K readOnlyKey, final V value) { | ||
new LineageHeaders(this.context.headers()) | ||
.addTopicHeader(this.context.topic()) | ||
.addPartitionHeader(this.context.partition()) | ||
.addOffsetHeader(this.context.offset()); | ||
return value; | ||
} | ||
|
||
@Override | ||
public void close() { | ||
// do nothing | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for adding lineage to a KTable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a table directly via the StreamsBuilder. And because there is also the transformer API available, I added it for completeness