Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JWKS keys without "alg" set #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support JWKS keys without "alg" set #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastapi_jwks/validators/jwks_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def jwks_data(self) -> dict[str, Any]:

@staticmethod
def __extract_algorithms(jwks_response: dict[str, Any]) -> list[str]:
return [key["alg"] for key in jwks_response["keys"]]
return [key["alg"] for key in jwks_response["keys"] if "alg" in key]

@cached_property
def __is_generic_passed(self):
Expand All @@ -63,7 +63,7 @@ def validate_token(self, token: str) -> DataT:
kid = header["kid"]
jwks_data = self.jwks_data()
provided_algorithms = self.__extract_algorithms(jwks_data)
if header["alg"] not in provided_algorithms:
if provided_algorithms and header["alg"] not in provided_algorithms:
logger.debug(
f"Could not find '{header['alg']}' in provided algorithms: {provided_algorithms}"
)
Expand Down