adding plan for the user #276
Conversation
|
now the lambda should add any type of plan not just vocab |
There was a problem hiding this comment.
Your changes to this page conflict with the UI changes to the page #287, and I'm not comfortable with the current use of useEffect, but I'll look into that later.
For now, I think you can either try to resolve the conflicts, and if you need help in that, get in contact with the rest of the team.
There was a problem hiding this comment.
Do we even need this page? Please confirm on me if we can just delete it or we still need it.
| ExpressionAttributeNames: { | ||
| '#planType': planType, | ||
| }, |
There was a problem hiding this comment.
Before this add a check to limit planType to only allowed values. Security 101: Don't trust user inputs!
stacks/ApiStack.ts
Outdated
| 'GET /startTest/{testType}': 'packages/functions/src/startTest.main', | ||
| 'GET /Listening/audio': { | ||
| function: { | ||
| handler: | ||
| 'packages/functions/src/sample-python-lambda/getListeningAudio.main', | ||
| handler: 'packages/functions/src/startTest.main', |
There was a problem hiding this comment.
This is the line causing the build issue.
|
@Ma-hawaj Take a second look at the backend code. |
|
@Ma-hawaj please review the new changes. |
|
@mzhubail I think everything is alright right now. |
adding the vocab plan