-
Notifications
You must be signed in to change notification settings - Fork 3
Adding new abstract potts proliferation module that does not progress through cell cycle #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jannetty
wants to merge
16
commits into
main
Choose a base branch
from
feature/add-phaseless-prolifmode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but a PottsModule
Contributor
|
Structurally it might make sense to still have a abstract PottsProliferationModule class that both the CellCycle and VolumeBased classes extends from instead of both of them extending from PottsModule directly since they're both still proliferation. The abstract class can just have step() and addCell() -- something to consider! |
allison-li-1016
approved these changes
Oct 21, 2025
…dCell must be defined in proliferation modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: agent
Related to the agent subpackages
package: potts
Related to the potts implementation
size: medium
Estimated size of issue or PR is medium
type: feature
Improvement or additions to the code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimated time to review: medium, maybe medium long, its a lot of files but only because I changed the name of a class.
Summary of changes: