-
Notifications
You must be signed in to change notification settings - Fork 3
Introduce a new ic tag #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o chiu/variance_only
|
Wouldn't the daughter cells also inherit the DegenerateDistribution? Maybe Im wrong, but Im of the understanding that the daughter cell inherits the parent cell's parameters in |
Just to make sure I understand the code correctly, does line 45 in the parameters class make sure that the daughter cells get the original distribution?
|
cainja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should degenerate distributions be added as an accessible distribution option from the input xml? If so, we should update minibox with the degenerate distribution.
| population.put("CAR_ANTIGENS", 0); | ||
| population.put("SELF_TARGETS", 0); | ||
| doReturn(population).when(factoryMock).getParameters(anyInt()); | ||
| Parameters parameters = new Parameters(population, null, randomMock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the important test - you need to make sure the daughter cells inherit the original distribution and not the degenerate distribution. This is how this happens in PatchModuleProliferation:
CellContainer newContainer = cell.make(newID, State.UNDEFINED, random);
Parameters newParameters = cell.getParameters();
PatchCell newCell =
(PatchCell)
newContainer.convert(
sim.getCellFactory(),
newLocation,
random,
newParameters);This test isn't actually testing how new cells are created, which is related to @allison-li-1016's question.
Summary
Introduce a new ic tag for parameters to enforce constant initial conditions for cellular properties, while ensuring that parameters for daughter cells continue to be drawn from a distribution.
Changes
Examples
In the input .xml file, we can set a
ictag for population.parameter.NaNvalue of the distribution if theictag does not match the distributionComments
I overrided the
parseParameterby introducing a new argument -MiniBox icsinstead of modify the original one.Estimated size: Small to Medium
Resolve #177.