Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump nock from 13.5.6 to 14.0.0; run [*****] #10855

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 31, 2025

Bumps nock from 13.5.6 to 14.0.0.

Release notes

Sourced from nock's releases.

v14.0.0

BREAKING CHANGES

  • drop support for Node < 18

Features

v14.0.0-beta.19

14.0.0-beta.19 (2024-12-04)

Bug Fixes

  • backport: memory leaks due to timer references outliving the timers (#2773) (#2773) (66eb7f4)
  • call fs.createReadStream lazily (#2357) (ba9fc42)
  • remove duplicates from activeMocks() and pendingMocks() (#2356) (7e957b3)
  • support literal query string (#2590) (4162fa8)
  • types: return type of BackOptions.afterRecord (#2782) (fc90bd3)

v14.0.0-beta.18

14.0.0-beta.18 (2024-11-25)

Bug Fixes

  • recorder: recompress fetch body on record (#2810) (be35f23)

v14.0.0-beta.17

14.0.0-beta.17 (2024-11-21)

Bug Fixes

  • fetch: add support for aborting requests using AbortSignal (#2809) (a143911)

v14.0.0-beta.16

14.0.0-beta.16 (2024-11-14)

Bug Fixes

  • fetch: support Content-Encoding response header (#2797) (451e69c)
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [nock](https://github.com/nock/nock) from 13.5.6 to 14.0.0.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md)
- [Commits](nock/nock@v13.5.6...v14.0.0)

---
updated-dependencies:
- dependency-name: nock
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Related to dependency updates javascript [dependabot only] Pull requests that update Javascript packages labels Jan 31, 2025
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@chris48s chris48s changed the title chore(deps-dev): bump nock from 13.5.6 to 14.0.0 chore(deps-dev): bump nock from 13.5.6 to 14.0.0; run [*****] Feb 2, 2025
@chris48s
Copy link
Member

chris48s commented Feb 2, 2025

OK, so I reckon the 3 failures on the core tests and the 2 BundleJs tests failing with

TypeError: Reflect.has called on non-object

are new with this release of nock. Also, the huge amount of log messages saying

(node:2834) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 connect listeners added to [MockHttpSocket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit

are new.

In theory, the only breaking change in this release should be dropping node 18 so if there are breaking changes we're supposed to account for, they're certainly not documented changes. I'm going to go out on a limb and say there are some bugs in this release.

I think as a next step, I'm just going to leave this one and see what the next 14.x release brings before I put a bunch of time into this.

@chris48s
Copy link
Member

chris48s commented Feb 4, 2025

Possible EventEmitter memory leak is: nock/nock#2830
Reflect.has called on non-object may be: nock/nock#2789

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 7, 2025

Superseded by #10868.

@dependabot dependabot bot closed this Feb 7, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nock-14.0.0 branch February 7, 2025 12:54
@mikicho
Copy link

mikicho commented Feb 7, 2025

@chris48s While we tried as much as possible to keep the changes to the API to the minimum for this release (we plan some improvements for the next one :)), under the hood, this change is pretty big, so even after a lengthy beta, we expected some bugs to pop up. So feel free to wait a little while before adopting this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates javascript [dependabot only] Pull requests that update Javascript packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants