Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix badge-maker package tests #10809

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix badge-maker package tests #10809

merged 1 commit into from
Jan 18, 2025

Conversation

chris48s
Copy link
Member

Refs #10794 (comment)

Whoops. I accidentally broke this in #10732
Basically, I inadvertently disabled some of the package tests and then didn't notice I'd missed some CommonJS --> ESM stuff because we were only running the CommonJS tests.

This PR fixes that.

@chris48s chris48s added the npm-package Badge generation and badge templates label Jan 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against d2ce53c

@chris48s chris48s mentioned this pull request Jan 12, 2025
Merged
LitoMore
LitoMore approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@LitoMore LitoMore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR on my local and looks good.

PyvesB
PyvesB approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏻

@chris48s chris48s added this pull request to the merge queue Jan 18, 2025
Merged via the queue into badges:master with commit 152b8e9 Jan 18, 2025
24 checks passed
@chris48s chris48s deleted the fix-package-tests branch January 18, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
npm-package Badge generation and badge templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris48s @LitoMore @PyvesB