Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [PUB] downloads badge #10745

Merged
merged 7 commits into from
Dec 23, 2024
Merged

add [PUB] downloads badge #10745

merged 7 commits into from
Dec 23, 2024

Conversation

G1Joshi
Copy link
Contributor

@G1Joshi G1Joshi commented Dec 14, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @G1Joshi!

Generated by 🚫 dangerJS against 55dcc42

PyvesB
PyvesB reviewed Dec 15, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @G1Joshi! A few comments online, but overall this is good work! 👍🏻

services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
@G1Joshi G1Joshi requested review from PyvesB and chris48s December 16, 2024 08:11
@G1Joshi
Copy link
Contributor Author

G1Joshi commented Dec 23, 2024

@PyvesB and @chris48s let me know if any further changes are required.

PyvesB
PyvesB approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution!

@PyvesB PyvesB added this pull request to the merge queue Dec 23, 2024
Merged via the queue into badges:master with commit 0cbc131 Dec 23, 2024
23 checks passed
@G1Joshi G1Joshi deleted the pub-downloads branch December 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

@chris48s chris48s Awaiting requested review from chris48s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add [PUB] downloads badge
3 participants
@G1Joshi @chris48s @PyvesB