Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump chai from 4.5.0 to 5.1.2 #10720

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 6, 2024

Bumps chai from 4.5.0 to 5.1.2.

Release notes

Sourced from chai's releases.

v5.1.2

What's Changed

Full Changelog: chaijs/chai@v5.1.1...v5.1.2

v5.1.1

What's Changed

New Contributors

Full Changelog: chaijs/chai@v5.1.0...v5.1.1

v5.1.0

What's Changed

New Contributors

Full Changelog: chaijs/chai@v5.0.3...v5.1.0

v5.0.3

Fix bad v5.0.2 publish.

Full Changelog: chaijs/chai@v5.0.2...v5.0.3

v5.0.2

What's Changed

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [chai](https://github.com/chaijs/chai) from 4.5.0 to 5.1.2.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@v4.5.0...v5.1.2)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Related to dependency updates javascript [dependabot only] Pull requests that update Javascript packages labels Dec 6, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +3 549 kB chaijs

🚮 Removed packages: npm/[email protected]

View full report↗︎

@chris48s
Copy link
Member

chris48s commented Dec 7, 2024

This PR and #10721 are failing due to peerDependency conflicts.

I think we're going to need to make one PR that bumps chai and all related chai- packages in one go.

shields/package.json

Lines 156 to 160 in d7bb13c

"chai": "^4.5.0",
"chai-as-promised": "^8.0.1",
"chai-datetime": "^1.8.1",
"chai-string": "^1.4.0",
"child-process-promise": "^2.2.1",

plus sinon-chai

One thing I have not worked out yet is whether all the chai-related packages we rely on yet have a chai 5 compatible version. Hopefully this will be a bit simpler than ESLint though as we only depend on a handful of chai extensions.

@chris48s
Copy link
Member

chris48s commented Dec 7, 2024

OK. The blocker to this is chai-string, which does not declare compatibility with chai 5.

I wonder what will be involved to make a PR upstream to chai-string 🤔

@chris48s
Copy link
Member

chris48s commented Dec 7, 2024

Hmm. The other issue we have here is that Chai 5 is ESM only and badge-maker still uses CommonJS. We might have to work round that too. Untested, but if that is the only problem we can probably just make the tests .mjs without having to migrate the whole package from cjs to esm.

@chris48s chris48s mentioned this pull request Dec 7, 2024
@chris48s
Copy link
Member

chris48s commented Dec 7, 2024

Picked this up in #10732

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 11, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/chai-5.1.2 branch December 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates javascript [dependabot only] Pull requests that update Javascript packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant