add throttleImmediate #712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoscur
commented
Feb 12, 2018
src/throttle.js
Outdated
| changes.debounce(delay) | ||
| ) | ||
| /*changes.flatMapFirst(value => | ||
| Bacon.once(value).concat(Bacon.later(delay).filter(false)) |
There was a problem hiding this comment.
@raimohanska this is debounceImmediate, but it doesn't work because it throws away events while debouncing.. it has to somehow know when something happens inbetween and in that case emit the latest event after the stream calmed down.
There was a problem hiding this comment.
I see! Needs a bit more thought then...
adjust tests a bit
|
Please reopen if this is still wanted, I haven't used Baconjs in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created tests for #702
Tried to borrow from the debounceImmediate implementation. Still searching for better solution.
@semmel merging creates duplicates as expected :/