Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bus end #576

Merged
merged 2 commits into from
May 11, 2015
Merged

Bus end #576

merged 2 commits into from
May 11, 2015

Conversation

phadej
Copy link
Member

@phadej phadej commented Apr 19, 2015

Includes commits from #573

@raimohanska
Copy link
Contributor

Hmm.. the "Bacon.Bus does not plug after end(), second variant" test is still failing.

@raimohanska
Copy link
Contributor

To me it seems that the test is wrong:

  it "does not plug after end(), second variant", ->
    failed = false
    busA = new Bacon.Bus()
    busB = new Bacon.Bus()
    busB.onValue(-> failed = true;)
    busB.plug(busA)
    busA.push('foo')
    busB.end()
    expect(failed).to.equal(false)

You plug busA before ending busB, so it's correct to pass the "foo" event through, right?

@phadej
Copy link
Member Author

phadej commented Apr 20, 2015

Ah seems, I swapped the lines when "cleaning up the mess".

@phadej
Copy link
Member Author

phadej commented Apr 20, 2015

Fixed.

@raimohanska raimohanska merged commit c33fa93 into baconjs:master May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants