build: Use PlantUML from Docker image to work with Renovate, remove pip cache - #92
Open
GabDug wants to merge 3 commits into
Open
build: Use PlantUML from Docker image to work with Renovate, remove pip cache#92GabDug wants to merge 3 commits into
GabDug wants to merge 3 commits into
Conversation
The jar was curl'd from a GitHub release and validated against a sha1sum that had to be regenerated by hand on every bump, so Renovate could not touch it. plantuml/plantuml packages the same release, and a tag + digest pin on COPY --from is something Renovate updates like any other image. Also replaces the `echo $'...'` wrapper with printf. $'' is a bashism: it happens to work under busybox ash here, but a shell without it writes a literal `$` into the shebang, which is the Exec format error the comment above the RUN warns about for the Backstage Backend container. printf behaves the same everywhere, so the warning keeps its point but no longer needs a second RUN variant to copy. `>` instead of `>>` also stops a layer rebuild from concatenating two scripts into the file. Verified with a local build for the pinned digest (multi-arch index, so the linux/arm64 leg still resolves): `plantuml -version` reports 1.2026.2, and `mkdocs build` on mock-docs renders the diagram. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
pip install wrote 31.5 MB of wheels and cached response bodies to /root/.cache/pip, which the layer then kept forever. Nothing in the container reads it: the install runs once at build time. Image goes from 737 MB to 705 MB. A ~1 MB http-v2 remainder survives --no-cache-dir, so it is not worth an extra rm. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
config:best-practices already extends helpers:pinGitHubActionDigests, but enabledManagers left out github-actions, so that half of the preset was dead config and no workflow pin has moved since it was written. The workflows are 1-3 majors behind as a result, including actions/checkout@v2 and actions/stale@v4.1.1. Expect the first run to open a batch of PRs: major bumps plus SHA pins for every action, per the preset already in use. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
GabDug
force-pushed
the
plantuml-from-official-image
branch
from
August 12, 2026 09:47
41c7041 to
18f6c78
Compare
GabDug
marked this pull request as ready for review
August 12, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, here's a few backports from our internal techdocs image setup, which should help with maintenance:
I've kept curl in the image to avoid breaking consumers workflows (e.g. if image is used in a CI to curl something?). Tested locally and seems fine :)
As a follow-up, I may also backport our uv setup, to have a lockfile and thus more reproducible builds if you're interested.
Cheers!