Merge pull request #927 from Zerthox/ren

Add instant cast detection for Renegade Band Together
baaron4 · Sep 2, 2024 · d105cb1 · d105cb1
2 parents b59832e + 72fd076
commit d105cb1
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/GW2EIEvtcParser/EIData/ProfHelpers/Revenant/RenegadeHelper.cs b/GW2EIEvtcParser/EIData/ProfHelpers/Revenant/RenegadeHelper.cs
@@ -12,6 +12,14 @@ namespace GW2EIEvtcParser.EIData
 {
     internal static class RenegadeHelper
     {
+        private class BandTogetherCastFinder : EffectCastFinder
+        {
+            public BandTogetherCastFinder(long baseSkillID, long enhancedSkill, string effect) : base(enhancedSkill, effect)
+            {
+                UsingSrcSpecChecker(Spec.Renegade);
+                UsingChecker((evt, combatData, agentData, skillData) => !combatData.IsCasting(baseSkillID, evt.Src, evt.Time));
+            }
+        }
 
         internal static readonly List<InstantCastFinder> InstantCastFinder = new List<InstantCastFinder>()
         {
@@ -20,7 +28,11 @@ internal static class RenegadeHelper
             new EffectCastFinder(OrdersFromAbove, EffectGUIDs.RenegadeOrdersFromAboveRighteousRebel)
                 .UsingSrcSpecChecker(Spec.Renegade),
             new EffectCastFinder(OrdersFromAbove, EffectGUIDs.RenegadeOrdersFromAbove)
-                .UsingSrcSpecChecker(Spec.Renegade)
+                .UsingSrcSpecChecker(Spec.Renegade),
+            new BandTogetherCastFinder(BreakrazorsBastionSkill, BreakrazorsBastionSkillEnhanced, EffectGUIDs.RenegadeBreakrazorsBastion),
+            new BandTogetherCastFinder(RazorclawsRageSkill, RazorclawsRageSkillEnhanced, EffectGUIDs.RenegadeRazorclawsRage),
+            new BandTogetherCastFinder(DarkrazorsDaringSkill, DarkrazorsDaringSkillEnhanced, EffectGUIDs.RenegadeDarkrazorsDaring),
+            new BandTogetherCastFinder(IcerazorsIreSkill, IcerazorsIreSkillEnhanced, EffectGUIDs.RenegadeIcerazorsIre),
         };
 
         internal static readonly List<DamageModifierDescriptor> OutgoingDamageModifiers = new List<DamageModifierDescriptor>

diff --git a/GW2EIEvtcParser/ParserHelpers/EffectGUIDs.cs b/GW2EIEvtcParser/ParserHelpers/EffectGUIDs.cs
@@ -210,6 +210,10 @@ public static class EffectGUIDs
         public const string RenegadeCitadelBombardmentPortal = "145B288ECA42CF43A40DFD759419C904";
         public const string RenegadeCitadelBombardment1 = "5BBF59761E6B9D49A91E79D5474CC61C";
         public const string RenegadeCitadelBombardment2 = "6C8201B551CF274C9C1AF51C33AA062A"; // duration 0
+        public const string RenegadeBreakrazorsBastion = "72FC15613B4B2C44A1906617998859F9";
+        public const string RenegadeRazorclawsRage = "71B04F91F9B3DF4A8954059FCFAD630E";
+        public const string RenegadeDarkrazorsDaring = "C8FDB04E59C1034CABEFBECE470AA1BC";
+        public const string RenegadeIcerazorsIre = "E725FC2FD486A84EBEAC403DB4DA30DE";
         #endregion
         #region Guardian
         public const string GuardianGenericFlames = "EA98C3533AA46E4A9B550929356B7277"; // used e.g. with judges intervention, signet of judgment

diff --git a/GW2EIEvtcParser/ParserHelpers/SkillIDs.cs b/GW2EIEvtcParser/ParserHelpers/SkillIDs.cs
@@ -4277,11 +4277,16 @@ public static class SkillIDs
         public const long InsatiableHunger17 = 72351;
         public const long InsatiableHunger19 = 72352;
         public const long IcerazorsIreSkillMinionReworked = 72353;
+        public const long POV_BandTogetherBuff = 72354;
+        public const long IcerazorsIreSkillEnhanced = 72359;
         public const long DarkrazorsDaringSkillMinionReworked = 72360;
+        public const long RazorclawsRageSkillEnhanced = 72363;
         public const long BreakrazorsBastionSkillMinionReworked = 72365;
+        public const long DarkrazorsDaringSkillEnhanced = 72366;
         public const long RazorclawsRageSkillMinionReworked = 72370;
         public const long SoulcleavesSummitHitReworked = 72376;
         public const long RazorclawsRageHitReworked = 72388;
+        public const long BreakrazorsBastionSkillEnhanced = 72389;
         public const long RageEmpowerment = 72399;
         public const long EnvyAttunement = 72403;
         public const long EnragedSmashEparch = 72437;