Add Content-Length header to responses #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes server responses more efficient by disabling chunked transfer encoding, but more importantly the Content-Length header is required for all requests and responses by the XML-RPC spec (see http://xmlrpc.scripting.com/spec.html).
|
This change makes node-xmlrpc compatible with XmlRpc++, the library used by C++ ROS clients (http://wiki.ros.org/xmlrpcpp). |
|
Ack, I should have checked the open PRs first. #138 includes this exact change plus a unit test. Closing this PR in favor of the previous one. Let me know if you need any help reviewing and merging PRs; it looks like this project is not actively maintained but it is still the most popular node.js xmlrpc lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes server responses more efficient by disabling chunked transfer encoding, but more importantly the Content-Length header is required for all requests and responses by the XML-RPC spec (see http://xmlrpc.scripting.com/spec.html).