Fix oppia#20958: Waiting for element to appear before checking for it…

…s existance (oppia#21186) * now the test waits for the review button to appear * fixed linting issue
ayush-pandey047 · Oct 29, 2024 · 996739e · 996739e
1 parent f0255f6
commit 996739e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/...ntributor-dashboard-page/contributions-and-review/contributions-and-review.component.html b/...ntributor-dashboard-page/contributions-and-review/contributions-and-review.component.html
@@ -46,7 +46,7 @@
     </div>
   </div>
   <div class="oppia-contributions-show-review-side-navbar-container" >
-    <div class="oppia-contributions-side-navbar-part" *ngIf="reviewTabs.length > 0" tabindex="0">
+    <div class="oppia-contributions-side-navbar-part e2e-test-available-task-label" *ngIf="reviewTabs.length > 0" tabindex="0">
       <div class="oppia-contributions-navbar-items-list" navbar-label="Available Tasks" aria-label="Available tasks">
         <div class="oppia-contributions-navbar-item e2e-test-review-buttons" *ngFor="let tab of reviewTabs">
           <button class="oppia-contributions-navbar-button"

diff --git a/core/tests/webdriverio_desktop/contributorAdminDashboard.js b/core/tests/webdriverio_desktop/contributorAdminDashboard.js
@@ -206,6 +206,7 @@ describe('Contributor Admin Dashboard', function () {
     // Accept suggestion as user1.
     await users.login(USER_EMAILS[1]);
     await contributorDashboardPage.get();
+    await contributorDashboardPage.waitForAvailableTaskLabelToAppear();
     await contributorDashboardPage.selectTranslationReviewButton();
     await contributorDashboardPage.waitForOpportunitiesToLoad();
     await contributorDashboardPage.selectReviewLanguage('shqip (Albanian)');

diff --git a/core/tests/webdriverio_utils/ContributorDashboardPage.js b/core/tests/webdriverio_utils/ContributorDashboardPage.js
@@ -26,6 +26,7 @@ var ContributorDashboardPage = function () {
   var navigateToTranslateTextTabButton = $('.e2e-test-translateTextTab');
   var submitQuestionTabButton = $('.e2e-test-submitQuestionTab');
   var myContributionTabButton = $('.e2e-test-myContributionTab');
+  var availableTaskLabel = $('.e2e-test-available-task-label');
   var opportunityLoadingPlaceholder = $(
     '.e2e-test-opportunity-loading-placeholder'
   );
@@ -341,6 +342,13 @@ var ContributorDashboardPage = function () {
     await this.waitForOpportunitiesToLoad();
   };
 
+  this.waitForAvailableTaskLabelToAppear = async function () {
+    await waitFor.visibilityOf(
+      availableTaskLabel,
+      'Opportunity taking too long to appear.'
+    );
+  };
+
   this.selectTranslationReviewButton = async function () {
     var reviewButtons = await reviewButtonsSelector();
     await action.click('Translation Review Button', reviewButtons[1]);