chore(codegen): Fix duplicate BPF_F_LINK #1154
Conversation
Per the comment added in the code, there are 2 definitions of BPF_F_LINK in the kernel headers. Once is in an anonymous enum which bindgen will constify, and once is via a #define macro. The values are identical. The fix is to exclude BPF_F_LINK from the list of variables in bindgen removing one of the duplicate definitions. Signed-off-by: Dave Tucker <[email protected]>
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dave-tucker and @vadorovsky)
xtask/src/codegen/aya.rs line 219 at r1 (raw file):
bindgen = bindgen .allowlist_var(x) // BPF_F_LINK is defined twice. Once in an anonymous enum
Curious, where is the enum? I only find https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/include/uapi/linux/bpf.h#L1210 which is the define.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vadorovsky)
xtask/src/codegen/aya.rs line 219 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
Curious, where is the enum? I only find https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/include/uapi/linux/bpf.h#L1210 which is the define.
Ah, it's here: https://github.com/libbpf/libbpf/blob/324f3c3846d99c8a1e1384a55591f893f0ae5de4/include/uapi/linux/bpf.h#L1400
|
Thanks for the fast review @tamird 🫡 |
Per the comment added in the code, there are 2 definitions of BPF_F_LINK in the kernel headers. Once is in an anonymous enum which bindgen will constify, and once is via a #define macro. The values are identical. The fix is to exclude BPF_F_LINK from the list of variables in bindgen removing one of the duplicate definitions.
This change is