Skip to content

Add close code and reason for Websocket close / onClose #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 1, 2025
Merged

Add close code and reason for Websocket close / onClose #2579

merged 10 commits into from
Jul 1, 2025

Conversation

AlexandreK38
Copy link
Contributor

This PR allows us to give a code and a reason to a websocket close and have these too on the onClose callback.

@AlexandreK38
Copy link
Contributor Author

I wasn't aware of string_view affection behavior, updated the code

halx99
halx99 reviewed Jun 27, 2025
View reviewed changes
halx99
halx99 requested changes Jun 30, 2025
View reviewed changes
@halx99 halx99 added the enhancement New feature or request label Jun 30, 2025
@halx99 halx99 added this to the 2.7.0 milestone Jul 1, 2025
@halx99 halx99 merged commit 59c0c95 into axmolengine:dev Jul 1, 2025
14 checks passed
@AlexandreK38 AlexandreK38 deleted the websocket-code-reason branch July 3, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halx99 halx99 halx99 approved these changes

+1 more reviewer

@paulocoutinhox paulocoutinhox paulocoutinhox left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreK38 @paulocoutinhox @halx99