feature: Reimplement lib transfers and an helper to unwrap token #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuDo1403
reviewed
Mar 25, 2025
TuDo1403
reviewed
Mar 25, 2025
TuDo1403
reviewed
Mar 25, 2025
TuDo1403
reviewed
Mar 25, 2025
Comment on lines
19
to
20
| bytes4 selector = IERC20.transferFrom.selector; | ||
| (bool success, bytes memory data) = token.call(abi.encodeWithSelector(selector, from, to, value)); |
There was a problem hiding this comment.
use standard logic for handling ERC20 transfer
TuDo1403
reviewed
Mar 25, 2025
src/transfers/LibTransferHelper.sol
Outdated
Comment on lines
19
to
20
| bytes4 selector = IERC20.transfer.selector; | ||
| (bool success, bytes memory data) = token.call(abi.encodeWithSelector(selector, to, value)); |
TuDo1403
reviewed
Mar 25, 2025
src/transfers/LibTransferHelper.sol
Outdated
Comment on lines
19
to
20
| bytes4 selector = IERC20.transfer.selector; | ||
| (bool success, bytes memory data) = token.call(abi.encodeWithSelector(selector, to, value)); |
TuDo1403
reviewed
Mar 25, 2025
TuDo1403
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request streamlines CI/CD by removing redundant GitHub Actions workflows and updates the Solidity development configuration while introducing new code for enhanced token transfer functionalities.
- Updated Solidity compiler settings and enabled optimizations in foundry.toml
- Changed the Foundry toolchain version used in tests from nightly to stable
Reviewed Changes
Copilot reviewed 2 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| foundry.toml | Updated compiler version, EVM target, and optimization settings |
| .github/workflows/test.yml | Changed the Foundry toolchain version from nightly to stable |
Files not reviewed (9)
- .github/workflows/create-PR-deploy-to-release.yml: Language not supported
- .github/workflows/create-PR-implement-to-feature.yml: Language not supported
- .github/workflows/create-PR-release-to-feature.yml: Language not supported
- .github/workflows/create-PR-release-to-network.yml: Language not supported
- src/transfers/LibNativeTransfer.sol: Language not supported
- src/transfers/LibRONTransferHelperExtended.sol: Language not supported
- src/transfers/LibTransferFromHelper.sol: Language not supported
- src/transfers/LibTransferHelper.sol: Language not supported
- src/transfers/helpers/UnwrapTokenAndTransferHelpers.sol: Language not supported
Comments suppressed due to low confidence (2)
foundry.toml:10
- Confirm that the updated EVM version 'cancun' is fully supported by all project dependencies and testing setups, as this major update may have compatibility implications.
evm_version = 'cancun'
.github/workflows/test.yml:35
- Validate that switching from the nightly to a stable Foundry toolchain does not inadvertently disable required experimental features or affect test behavior.
version: stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several significant changes to the repository, primarily focusing on the removal of various GitHub Actions workflows and the addition of new Solidity libraries and helper functions for token transfers. Below is a summary of the most important changes:
Removal of GitHub Actions Workflows:
.github/workflows/create-PR-deploy-to-release.yml: Removed the workflow responsible for creating pull requests to deploy to the release branch..github/workflows/create-PR-implement-to-feature.yml: Removed the workflow for creating pull requests from implement to feature branches..github/workflows/create-PR-release-to-feature.yml: Removed the workflow for creating pull requests from release to feature branches..github/workflows/create-PR-release-to-network.yml: Removed the workflow for creating pull requests from release to network branches.Solidity Code Enhancements:
foundry.toml: Updated the Solidity compiler version to0.8.27and enabled optimization with 200 optimizer runs.src/transfers/LibNativeTransfer.sol: Added a constantDEFAULT_GAS_AMOUNTand a new functionsafeTransferfor transferring native coins with a fixed gas amount.src/transfers/LibRONTransferHelperExtended.sol: Introduced a new libraryLibRONTransferHelperExtendedfor safely unwrapping WRON tokens and transferring them, with support for proxy contracts.src/transfers/LibTransferFromHelper.sol: Added a new libraryLibTransferFromHelperto wrap transfer-from methods for ERC20 tokens.src/transfers/LibTransferHelper.sol: Added a new libraryLibTransferHelperto wrap transfer methods for ERC20/native tokens.src/transfers/helpers/UnwrapTokenAndTransferHelpers.sol: Introduced a new contractUnwrapTokenAndTransferHelpersfor unwrapping WRON tokens and batch transferring RON to recipients.These changes aim to streamline the CI/CD process by removing redundant workflows and enhance the Solidity codebase with new functionalities for token transfers.
Checklist