add json schemas #4

AndyOGo · 2019-03-05T11:49:50Z

Added

Adds JSON schemas for all existing operators
Extended remote tests to also validate the logic by json schema

AndyOGo · 2019-03-05T16:22:30Z

schemas/operators/accessor/variable.json

@@ -0,0 +1,55 @@
+{


I hope this schema implements all features documented here:
http://jsonlogic.com/operations.html#var

AndyOGo · 2019-03-05T16:44:01Z

schemas/operators/logic/equal.json

+            "title": "Any"
+          },
+          {
+            "$ref": "http://jsonlogic.com/schemas/operators/operators/variable.json"


Are there any other possible items for logical operators?
http://jsonlogic.com/operations.html#logic-and-boolean-operations

AndyOGo · 2019-03-05T17:06:46Z

schemas/operators/accessor/missingSome.json

@@ -0,0 +1,28 @@
+{


http://jsonlogic.com/operations.html#missing_some

@lina-salih
@mjenny
May we should strictly keep the original underscore-case 🤔
missingSome to missing_some, same for all other files #11

it should be consistent :)

I renamed this one, all others within a separate PR

AndyOGo · 2019-03-14T12:06:24Z

schemas/common/all-types.json

+
+  "title": "All",
+  "description": "Any valid JSON data type.",
+  "type": ["array", "boolean", "null", "number", "object", "string"]


We need this for hardcoded static values...
But it forces us to use anyOf instead of oneOf below 🤔

AndyOGo · 2019-03-14T12:07:22Z

schemas/common/any.json

+    { "$ref": "http://jsonlogic.com/schemas/operators/string/cat.json" },
+    { "$ref": "http://jsonlogic.com/schemas/operators/string/substr.json" },
+
+    { "$ref": "http://jsonlogic.com/schemas/common/all-types.json" }


This schema is very loose, mainly because the API itself is very forgiving

I think in this case a forgiving APi is nice

AndyOGo · 2019-03-15T08:33:54Z

schemas/operators/misc/method.json

+  "$id": "http://jsonlogic.com/schemas/operators/misc/method.json",
+
+  "title": "method",
+  "description": "If your rule needs to call a method on an object, you can use the built-in method operation.\n You can also pass an array of arguments into the methot.",


@lina-salih
@mjenny
The only operator documented on a other page:
http://jsonlogic.com/add_operation.html#calling-methods-on-objects

l-salih

NICE!

l-salih · 2019-03-15T12:24:59Z

schemas/common/any.json

+    { "$ref": "http://jsonlogic.com/schemas/operators/string/cat.json" },
+    { "$ref": "http://jsonlogic.com/schemas/operators/string/substr.json" },
+
+    { "$ref": "http://jsonlogic.com/schemas/common/all-types.json" }


I think in this case a forgiving APi is nice

l-salih · 2019-03-15T12:26:02Z

schemas/common/pointer.json

+    {
+      "type": "number",
+      "title": "Index",
+      "description": "You can also use the var operator to access an array by numeric index."


l-salih · 2019-03-15T12:28:23Z

schemas/common/trinary-args.json

+      "description": "An array with one or three elements.",
+      "type": "array",
+      "minItems": 1,
+      "maxItems": 3,


Isn't it enough when we provide one-or-more args?

I thought so too at the beginning, then I saw that for example + and * take any number of arguments from 1 to infinity.
But - and / take only up to 2 - no more.

And then there are other special ops which take up to 3 like < and <= (in contrast to > and >=).

if is the most complex number of args, it 2n + 1, so 1, 3, 5, 7, 9, etc.

To make all of this even more complex, all operators support a single argument without an array.
It even doesn't matter if the provided number of arguments make sense, jsonLogic.apply will try it's best to never fail and output nonsense in the worst case 😅

l-salih · 2019-03-15T12:29:46Z

schemas/common/unary-arg.json

+  "oneOf": [
+    {
+      "title": "Single Array",
+      "description": "An array with just one element.",


I think unary and one-or-more args cover all constellations 🤔

l-salih · 2019-03-15T12:32:05Z

schemas/operators/accessor/missingSome.json

@@ -0,0 +1,28 @@
+{


it should be consistent :)

AndyOGo added the enhancement New feature or request label Mar 5, 2019

AndyOGo self-assigned this Mar 5, 2019

AndyOGo changed the title ~~chore: npm i ajv ajv-cli~~ add json schemas Mar 5, 2019

AndyOGo force-pushed the feature/add-json-schemas-for-aletheia branch from f100fde to 49347e8 Compare March 5, 2019 16:21

AndyOGo commented Mar 5, 2019

View reviewed changes

AndyOGo added 23 commits March 7, 2019 11:26

chore: npm i ajv ajv-cli

b021254

feat: setup basic schemas

79816f1

feat: implement schema for var

4abb538

feat: start adding strict equal schema

6a49a69

feat: start adding strict not-equal schema

8655dfb

feat: start adding equal schema

dd903eb

feat: start adding not-equal schema

7c4db53

refactore: extract common schemas

3395183

refactore: reuse common schemas

f076b21

refactore: extracted var into common

3f7192d

refactore: resue common var

ff5b6dc

feat: added missing_some schema

4f3ffca

feat: added any and unary common schemas

9b48163

feat: added thruthy and falsy schemas

4579c0e

feat: added common one-or-more args schema

d620029

feat: added and schema

a4adbb2

feat: added or shema

ef11e87

feat: added binary arg schema

8da53db

feat: added common trinary arg schema

322305e

feat: added greater schema

c8afad6

feat: added greater equal schema

3373fd3

feat: added lower schema

29d2b26

feat: added lower euwal schema

a54c284

feat: added substract schema

e4c3dfe

AndyOGo requested review from l-salih and storm1ng March 7, 2019 13:16

AndyOGo added 10 commits March 14, 2019 10:44

feat: added log schema

5fd8381

feat: added boilerplate schema for remaining array and string schemas

65d2af6

fix: added missing required field

ed8cb06

feat: added if schema

8e8d87e

feat: precise array args

59b156f

feat: added in schema

368a8a2

feat: added all ops to any

19d36a1

fix: invalid json schema

6ad80d8

teat: added lint script for json schemas themselve

6feef28

fix: comparison ops are binary args

d70bf54

AndyOGo force-pushed the feature/add-json-schemas-for-aletheia branch from 5b02725 to d70bf54 Compare March 14, 2019 10:59

AndyOGo added 3 commits March 14, 2019 12:58

fix: oneOf will never work with basic any typing...

845e8cb

chore: npm i glob

a0db8a7

test: validate all remote test casesby json schema

ce9c892

AndyOGo commented Mar 14, 2019

View reviewed changes

feat: added unknown method schema

0753e40

AndyOGo force-pushed the feature/add-json-schemas-for-aletheia branch from 8381e38 to 0753e40 Compare March 15, 2019 08:26

AndyOGo added 2 commits March 15, 2019 09:29

feat: added title and description for JSON Logic

aa199c3

feat: added description for method

e77dbb6

AndyOGo commented Mar 15, 2019

View reviewed changes

l-salih approved these changes Mar 15, 2019

View reviewed changes

AndyOGo added 2 commits March 15, 2019 14:39

fix: case for missing_some

e60b575

fix: typo

1827239

AndyOGo merged commit 8aec89c into master Mar 15, 2019

AndyOGo deleted the feature/add-json-schemas-for-aletheia branch March 15, 2019 13:54

AndyOGo mentioned this pull request Mar 18, 2019

JSON Schema jwadhams/json-logic-js#55

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add json schemas #4

add json schemas #4

AndyOGo commented Mar 5, 2019 •

edited

Loading

AndyOGo Mar 5, 2019

AndyOGo Mar 5, 2019

AndyOGo Mar 5, 2019

AndyOGo Mar 15, 2019 •

edited

Loading

l-salih Mar 15, 2019

AndyOGo Mar 15, 2019

AndyOGo Mar 14, 2019 •

edited

Loading

AndyOGo Mar 14, 2019

l-salih Mar 15, 2019

AndyOGo Mar 15, 2019

l-salih left a comment

l-salih Mar 15, 2019

l-salih Mar 15, 2019

l-salih Mar 15, 2019

AndyOGo Mar 15, 2019

l-salih Mar 15, 2019

l-salih Mar 15, 2019

add json schemas #4

add json schemas #4

Conversation

AndyOGo commented Mar 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndyOGo Mar 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndyOGo Mar 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l-salih left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndyOGo commented Mar 5, 2019 •

edited

Loading

AndyOGo Mar 15, 2019 •

edited

Loading

AndyOGo Mar 14, 2019 •

edited

Loading