Repository navigation
fix(packaging): publish updated parent image and volume size on update - #203
Merged
Merged
Conversation
Updating a recipe version published RecipeVersionUpdateStarted with the parent image and volume size the version had before the update, so the Image Builder recipe was rebuilt from the old values. The event now carries the values from the update.
This was referenced Nov 16, 2026
raphaho
approved these changes
Nov 16, 2026
raphaho
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ganhammar, nice catch: the event now carries the values that were just saved, and the test uses different old and new values, so it guards the bug. Checked that RecipeVersionUpdateStarted only feeds DeployRecipeVersion, and that the new test fails without the fix. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Updating a recipe version saves the new base image and volume size, but publishes
RecipeVersionUpdateStartedwith the values the version had before the update. The Image Builder recipe is then rebuilt from the old values. So a changed volume size, or a default base image that has moved since the version was created, shows up in VEW but never reaches the build.The event now carries the parent image resolved for the update and the volume size from the command, the same values that are saved.
Type of change
How was this tested?
A new unit test checks that the event carries the updated parent image and volume size. The recipe command handler tests pass. I found this by reading the code and have not reproduced it on a deployed VEW.
Checklist
CONTRIBUTING.mdNotes for reviewers
This was part of #116. I split it out because it stands on its own.
Acknowledgment
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.