Skip to content

fix(packaging): publish updated parent image and volume size on update - #203

Merged
raphaho merged 1 commit into
awslabs:mainfrom
ganhammar:fix/recipe-version-update-event
Nov 16, 2026
Merged

raphaho merged 1 commit into
awslabs:mainfrom
ganhammar:fix/recipe-version-update-event

Conversation

@ganhammar

Copy link
Copy Markdown
Contributor

What does this change do?

Updating a recipe version saves the new base image and volume size, but publishes RecipeVersionUpdateStarted with the values the version had before the update. The Image Builder recipe is then rebuilt from the old values. So a changed volume size, or a default base image that has moved since the version was created, shows up in VEW but never reaches the build.

The event now carries the parent image resolved for the update and the volume size from the command, the same values that are saved.

Type of change

  • Bug fix
  • New feature
  • Refactor / tech debt
  • Documentation
  • Infrastructure / CI

How was this tested?

A new unit test checks that the event carries the updated parent image and volume size. The recipe command handler tests pass. I found this by reading the code and have not reproduced it on a deployed VEW.

Checklist

  • Follows the guidance in CONTRIBUTING.md
  • Tests added/updated and passing locally
  • Lint / type checks pass locally
  • No secrets, credentials, or account IDs committed
  • Docs updated if behavior or usage changed (no docs change needed)
  • Linked the related issue (if any): none

Notes for reviewers

This was part of #116. I split it out because it stands on its own.

Acknowledgment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Updating a recipe version published RecipeVersionUpdateStarted with the parent image and volume size the version had before the update, so the Image Builder recipe was rebuilt from the old values. The event now carries the values from the update.

@raphaho raphaho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ganhammar, nice catch: the event now carries the values that were just saved, and the test uses different old and new values, so it guards the bug. Checked that RecipeVersionUpdateStarted only feeds DeployRecipeVersion, and that the new test fails without the fix. Approving.

@raphaho
raphaho merged commit 8d0bc83 into awslabs:main Nov 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants