-
Notifications
You must be signed in to change notification settings - Fork 49
Expose cipher suite TLSv1_2_2025_07 #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… cipher_suites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to have the tests check is supported and tls context creation rather than go through mqtt5?
awscrt/io.py
Outdated
"""A TLS Cipher Preference ordering that supports TLS 1.2 through TLS 1.3, and does not include CBC cipher suites. | ||
It is FIPS-complaint.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debatable: While the does not include CBC cipher suites
part is true, and that's what we originally requested from s2n, there are more differences. See aws/s2n-tls#5375
When I added the policy to c-io, I used abstract tightened security
, but now thinking more about it, maybe we should give details on what this preference provides, something like the following:
A TLS cipher preference requiring TLS 1.2+ with FIPS compliance and perfect forward secrecy. Supports AES-GCM and ECDHE cipher suites with ECDSA and RSA-PSS signature schemes. Uses NIST P-256 and P-384 curves only.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.