Add init functions to support thread safe init of impls #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Mar 26, 2025
waahm7
approved these changes
Mar 26, 2025
include/aws/checksums/checksums.h
Outdated
Comment on lines
17
to
18
| * which some tools picked up as thread unsafe. As best practice prefer explicit init | ||
| * before using this library. |
There was a problem hiding this comment.
Should we just say that you must call this? It would be weird trying to maintain where people may or may not call library init. It will be a breaking change, but if in the future someone just adds something to the init, it might break some people if we don't enforce this now.
There was a problem hiding this comment.
Agree with Waqar. Say it is required
There was a problem hiding this comment.
ok, reworded to make it stronger.
waahm7
reviewed
Mar 26, 2025
graebm
reviewed
Mar 26, 2025
include/aws/checksums/checksums.h
Outdated
Comment on lines
17
to
18
| * which some tools picked up as thread unsafe. As best practice prefer explicit init | ||
| * before using this library. |
There was a problem hiding this comment.
Agree with Waqar. Say it is required
waahm7
approved these changes
Mar 26, 2025
Co-authored-by: Waqar Ahmed Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
relevant issue aws/aws-sdk-cpp#3350
we lazily initialize impls on the first call. some tools will detect it as thread unsafe, even if in practice it is safe.
add explicit init functions to work around the problem.
In addition some minor cleanup is done on exports header.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.