Skip to content

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jun 25, 2025

Issue #, if available:

Description of changes:

  • Since NO_PROXY has no standard yet. https://about.gitlab.com/blog/we-need-to-talk-no-proxy/ and likely won't have any standard in the foreseeable future (there been many discussions but none of them really driving to a conclusion.).
  • It's also very tricky about how to match the host and IP address, and how to handle concern cases and invalid cases.
  • In the end, I decided to follow exactly the curl implementation from noproxy.c at 8.14.1
  • The implementation basically replicated the CURL logic.
  • All the CIDR and host validation all followed how CURL implement it.
  • Given no standards, we are taking curl as the the standard here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK changed the title no proxy support no_proxy excatly like CURL Jun 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.60%. Comparing base (a04c10a) to head (4e66b53).

Files with missing lines Patch % Lines
source/no_proxy.c 94.39% 6 Missing ⚠️
source/proxy_connection.c 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   79.62%   79.60%   -0.03%     
==========================================
  Files          27       28       +1     
  Lines       11702    11812     +110     
==========================================
+ Hits         9318     9403      +85     
- Misses       2384     2409      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK merged commit bfa0392 into main Jul 16, 2025
45 checks passed
@TingDaoK TingDaoK deleted the no-proxy branch July 16, 2025 01:48
@DmitriyMusatkin DmitriyMusatkin changed the title support no_proxy excatly like CURL support no_proxy exactly like CURL Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants