Update h2 windowing algo & Http Client benchmark #388

TingDaoK · 2022-08-26T00:04:56Z

Initial build of our http client benchmark
Test using a local host, that using our http client to connect to the host and collect how many requests are made during a certain time.
To run:
- start the python local host: https://github.com/awslabs/aws-c-http/tree/main/tests/py_localhost
- build aws-c-http with AWS_BUILD_CANARY=ON cmake flag
- cd build/bin/canary && ./canary

ISSUE FOUND & FIXED

We update the window for connection for each data frame received, which really slows us down for frequent small chunk of data frames receiving.
- We fixed it by only update the connection window whenever it drops to 50% of the max.
- Same issue may happens to streams windows
- Or the padding of the connection window.
Providing tiny increments to flow control in WINDOW_UPDATE frames can cause a sender to generate a large number of DATA frames. from here
- Is the client's responsibility to make sure not doing this? Even if the user do manual window update and doing small window update?
h2: respect the initial window size setting #514

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lgtm-com · 2022-09-12T21:49:46Z

This pull request introduces 1 alert when merging 4cd7338 into f81ee94 - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com · 2022-09-12T22:02:00Z

This pull request introduces 1 alert when merging f445de0 into f81ee94 - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com · 2022-09-12T22:09:04Z

This pull request introduces 1 alert when merging f86a9f7 into f81ee94 - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com · 2022-09-12T22:17:37Z

This pull request introduces 1 alert when merging ca0c7c5 into f81ee94 - view on LGTM.com

new alerts:

1 for Variable defined multiple times

bin/canary/CMakeLists.txt

bin/canary/main.c

DmitriyMusatkin · 2022-09-16T18:36:01Z

source/h2_connection.c

@@ -1762,6 +1767,8 @@ static void s_handler_installed(struct aws_channel_handler *handler, struct aws_
        aws_linked_list_push_back(
            &connection->thread_data.outgoing_frames_queue, &connection_window_update_frame->node);
        connection->thread_data.window_size_self += initial_window_update_size;
+        /* For automatic window management, we only update connectio windows when it droped blow 50% of MAX. */
+        connection->thread_data.window_size_self_dropped_threshold = AWS_H2_WINDOW_UPDATE_MAX / 2;


nit: pull this magic number into a constant?

it's derive from a constant... and it's more clear about where it comes from/

TingDaoK · 2025-04-02T22:10:22Z

tests/test_localhost_integ.c

@@ -408,12 +408,6 @@ static int s_localhost_integ_h2_upload_stress(struct aws_allocator *allocator, v
    s_tester.alloc = allocator;

    size_t length = 2500000000UL;
-#ifdef AWS_OS_LINUX


remove this, since it seems to be the flow control window issue.

we sent out too much

the initial window from the local server is small (default to the magic 65535). https://httpwg.org/specs/rfc7540.html#iana-settings

The local server code also update the window as data received.

Don't know why it matters that much for linux comparing to the other platform. (I think we do found this windowing issue affect linux more as well from the canary before, which matches this)

bin/canary/CMakeLists.txt

CMakeLists.txt

bin/canary/CMakeLists.txt

integration-testing/http_client_canary.py

bin/canary/main.c

tests/py_localhost/server.py

include/aws/http/private/h2_connection.h

source/h2_connection.c

source/h2_stream.c

graebm · 2025-04-18T20:29:33Z

include/aws/http/connection.h

+     * drops below the threshold.
+     * Default to half of the initial connection flow-control window size, which is 32767.
+     */
+    uint32_t conn_window_size_threshold_to_send_update;


extremely debatable: you could just leave these out of the public options, until someone actually asks for it

I think we can keep it. It makes the documentation easier to explain the behavior.😉

graebm · 2025-04-18T20:34:05Z

include/aws/http/private/h2_connection.h

+         * The client will send the WINDOW_UPDATE frame to the server only valid.
+         * If the pending_window_update_size is too large, we will leave the excess to send it out later.
+         */
+        uint64_t pending_window_update_size_thread;


utterly trivial. It's already in a struct named thread_data, no need to repeat

Suggested change

uint64_t pending_window_update_size_thread;

uint64_t pending_window_update_size;

or

Suggested change

uint64_t pending_window_update_size_thread;

uint64_t pending_window_update_size_self;

graebm · 2025-04-18T20:35:18Z

include/aws/http/private/h2_connection.h

@@ -150,7 +165,7 @@ struct aws_h2_connection {
        bool is_cross_thread_work_task_scheduled;

        /* The window_update value for `thread_data.window_size_self` that haven't applied yet */
-        size_t window_update_size;
+        uint64_t pending_window_update_size_sync;


trivial: it's already in synced_data.

Suggested change

uint64_t pending_window_update_size_sync;

uint64_t pending_window_update_size;

or

Suggested change

uint64_t pending_window_update_size_sync;

uint64_t pending_window_update_size_self;

graebm · 2025-04-18T20:38:37Z

include/aws/http/private/h2_connection.h

@@ -150,7 +165,7 @@ struct aws_h2_connection {
        bool is_cross_thread_work_task_scheduled;

        /* The window_update value for `thread_data.window_size_self` that haven't applied yet */


Suggested change

/* The window_update value for `thread_data.window_size_self` that haven't applied yet */

/* Value for `thread_data.pending_window_update_size` that we haven't applied yet */

graebm · 2025-04-18T20:43:54Z

include/aws/http/private/h2_stream.h

+         * The client will send the WINDOW_UPDATE frame to the server only valid.
+         * If the pending_window_update_size is too large, we will leave the excess to send it out later.
+         **/
+        uint64_t pending_window_update_size_thread;


source/h2_connection.c

source/h2_stream.c

graebm

all my feedback was style stuff. Looks good overall

TingDaoK added 4 commits August 25, 2022 15:26

http2 stream manager canary

c28c43b

add an error handling to make sure no request failed in the middle

c0b4ce4

add direct connection test

0247e69

add todo

06ab9a8

TingDaoK changed the title ~~Canary~~ Http Client benchmark Aug 26, 2022

TingDaoK added 3 commits August 26, 2022 11:06

nginx test

def775f

try to get it running from CI

9197dc6

maybe we will have canary as elasticurl in the future

4cd7338

fix build

f445de0

TingDaoK added 2 commits September 12, 2022 15:03

increase timeout

37696e2

print out output

f86a9f7

give me a nicer printout

ca0c7c5

TingDaoK added 4 commits September 12, 2022 22:47

unused arg

53d8d43

not updating the window so frequently

6f2c30a

my computers dead, disable it for now

2199444

try to fix it

2a23d4f

TingDaoK marked this pull request as ready for review September 12, 2022 23:53

TingDaoK added 8 commits September 12, 2022 17:00

why it's committed

a34e410

update window when larger

8e9ffd5

format

fc4769c

check the number is not slower than expected

2f0dcf4

result mem

c6a1676

add documentation and same thing for stream

e4c01fe

fix tests

db1a728

30 secs instead

9c89ade

DmitriyMusatkin reviewed Sep 16, 2022

View reviewed changes

TingDaoK commented Apr 2, 2025

View reviewed changes

graebm reviewed Apr 3, 2025

View reviewed changes

get the benchmark

46445c0

TingDaoK changed the title ~~Http Client benchmark~~ Update windowing algo & Http Client benchmark Apr 7, 2025

TingDaoK changed the title ~~Update windowing algo & Http Client benchmark~~ Update h2 windowing algo & Http Client benchmark Apr 7, 2025

TingDaoK added 2 commits April 7, 2025 16:05

Cap the window to max

e6eaa1d

almost there

7779645

TingDaoK marked this pull request as draft April 8, 2025 22:58

TingDaoK added 3 commits April 17, 2025 10:06

Merge branch 'main' into canary

4c8d477

a bunch of fix

eef6e31

conversion

a2cee45

TingDaoK marked this pull request as ready for review April 18, 2025 20:21

graebm reviewed Apr 18, 2025

View reviewed changes

graebm approved these changes Apr 18, 2025

View reviewed changes

TingDaoK added 13 commits April 24, 2025 16:09

address comments

af4c962

add comments

37adfb2

h2: respect the initial window size setting (#514)

19d9439

WIP

84d623c

Merge branch 'canary' of github.com:awslabs/aws-c-http into canary

ca5c938

add tests

c66b19f

add one more tricky test

af0a797

Merge branch 'main' into canary

c19bd6f

math

1e6e25e

Merge branch 'canary' of github.com:awslabs/aws-c-http into canary

3b24f4f

omg, this thing is so complicated

932b2a5

windows

f5868b9

adding comments to the local server impl

196e517

TingDaoK merged commit ca7e0e2 into main Apr 29, 2025
42 checks passed

TingDaoK deleted the canary branch April 29, 2025 21:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update h2 windowing algo & Http Client benchmark #388

Update h2 windowing algo & Http Client benchmark #388

TingDaoK commented Aug 26, 2022 •

edited

Loading

lgtm-com bot commented Sep 12, 2022

lgtm-com bot commented Sep 12, 2022

lgtm-com bot commented Sep 12, 2022

lgtm-com bot commented Sep 12, 2022

DmitriyMusatkin Sep 16, 2022

TingDaoK Apr 1, 2025

TingDaoK Apr 2, 2025 •

edited

Loading

graebm Apr 18, 2025

TingDaoK Apr 24, 2025

graebm Apr 18, 2025

graebm Apr 18, 2025

graebm Apr 18, 2025

graebm Apr 18, 2025

graebm left a comment

	uint64_t pending_window_update_size_thread;
	uint64_t pending_window_update_size;

	uint64_t pending_window_update_size_thread;
	uint64_t pending_window_update_size_self;

	uint64_t pending_window_update_size_sync;
	uint64_t pending_window_update_size;

		@@ -150,7 +165,7 @@ struct aws_h2_connection {
		bool is_cross_thread_work_task_scheduled;

		/* The window_update value for `thread_data.window_size_self` that haven't applied yet */

	/* The window_update value for `thread_data.window_size_self` that haven't applied yet */
	/* Value for `thread_data.pending_window_update_size` that we haven't applied yet */

Update h2 windowing algo & Http Client benchmark #388

Update h2 windowing algo & Http Client benchmark #388

Conversation

TingDaoK commented Aug 26, 2022 • edited Loading

ISSUE FOUND & FIXED

lgtm-com bot commented Sep 12, 2022

lgtm-com bot commented Sep 12, 2022

lgtm-com bot commented Sep 12, 2022

lgtm-com bot commented Sep 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingDaoK Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

graebm left a comment

Choose a reason for hiding this comment

TingDaoK commented Aug 26, 2022 •

edited

Loading

TingDaoK Apr 2, 2025 •

edited

Loading