-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Added KB examples and tests and updated metadata file #7451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…agraphs in incorrect segments to correct custom blocks. Some information was lost, for list flows, which does not have a current scenario in metadata.
…-doc-sdk-examples into gausekha-kb-python-examples
…-doc-sdk-examples into gausekha-kb-python-examples
@gausekha Looks like you're failing the linting at this point. If you can get that fixed up, we should be able to get this merged soon. |
@beqqrry-aws Is it this error? Just checking. For some reason, KB requires a certain range of uuid values and I had to add this change for the tests to pass. Do you have any suggestions around this if that's the case? error: |
Yes, that looks to be the error. My guess is it's having trouble understanding the concatenation inside of a dictionary value. Try encapsulating the whole thing in an f string instead, so it can be parsed as a single value. |
@gausekha , I saw this was still unmerged and I made a couple adjustments to the text and the tests, to get the tests and the PR checks passing again. If you agree with them and comment here, I will merge it. |
Yes, thanks so much @rlhagerm they look good to me! Also, apologies for the delay @beqqrry-aws ! I have been a bit heads down and didn't get a chance to look at the linting issue. I'll try to resolve it this week if possible but if not it may have to wait until next week. Apologies for the delay! |
@gausekha , I resolved the linting issue for you also. Merging today. |
Awesome, thanks so much for taking care of that as well, Rachel! :) |
This pull request adds code examples for the APIs CreateKnowledgeBase, GetKnowledgeBase, UpdateKnowledgeBase, DeleteKnowledgeBase, and ListKnowledgeBases APIs. The same submission was made earlier but running the writeme created a large number of file diffs. This submission hopes to avoid such a large commit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.