fix: adjust buffer size for awslogs driver in non-blocking mode #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the detailed investigation and solution. Please review the lint complaint. |
konoui
force-pushed
the
fix-awslogs-with-non-blocking-mode
branch
from
0a36903 to
7063065
Compare
|
@BinSquare, Thank you for pointing this out. I have addressed the lint error. |
konoui
changed the title
|
Sorry, I misunderstood. I've corrected the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#239
Description of changes:
The buffered logger uses
maximumBytesPerEventinstead ofdefaultAwsBufSizeInBytesto avoid unexpected log splitting.Before the fix, the e2e test failed with
a the number of test log lines are not matchingerror.After the fix, the e2e test passes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.