Skip to content

Conversation

@valerena
Copy link
Contributor

@valerena valerena commented Jan 3, 2026

The tests were outdated, so we updated domains and hosted zones, so we need to update the expected values here.

Issue #, if available

Integration tests were failing.

Description of changes

Updated the hosted zone and domain name for the tests, so the value of generated hashes for ApiGW Domain (depends on the domain name) and RecordSetGroup (depends on the hosted zone id) had to be updated.

Description of how you validated changes

$ pytest --no-cov --reruns 0 integration/combination/test_custom_rest_api_domains.py --prefix SamTranslatorLambda --internal --parameter-values template_parameter_values_new.yaml --stage prod
$ pytest --no-cov --reruns 0 integration/combination/test_custom_http_api_domains_test.py --prefix SamTranslatorLambda --internal --parameter-values template_parameter_values_new.yaml --stage prod

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The tests were outdated, so we got domains and hosted zones updated, so
we need to update the values expected by the tests.
@valerena valerena requested a review from a team as a code owner January 3, 2026 01:08
@seshubaws
Copy link
Contributor

Looks like a linting error is causing the tests to fail

self.assertEqual("ftl.sam-gamma-regional.com", result["domainName"])
else:
self.assertEqual("sam-gamma-regional.com", result["domainName"])
self.assertEqual(f"sam-gamma-regional.{CUSTOM_DOMAIN_TOP_LEVEL}", result["domainName"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: For the test, shouldn't we use tooling.lambda.aws.dev instead of the variable? So that if we mistakenly modify the CUSTOM_DOMAIN_TOP_LEVEL, the test should be able catch it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That variable is only used here for the tests and not anywhere in the code. The only purpose is to not have to repeat the full name everywhere, and we can have a single place with the domain that we use for all tests.

@valerena
Copy link
Contributor Author

valerena commented Jan 5, 2026

Looks like a linting error is causing the tests to fail

fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants