Repository navigation
fix(core): place repack dependencies in code root - #6460
Open
lucasjia-aws wants to merge 1 commit into
Open
lucasjia-aws wants to merge 1 commit into
lucasjia-aws wants to merge 1 commit into
Conversation
Copy directory and file dependencies alongside inference code so SageMaker inference toolkits can import them without extending sys.path. Preserve the existing copytree collision error and copy2 file overwrite behavior. Fixes aws#3491
There was a problem hiding this comment.
🤖 AI code review
This PR changes _create_or_update_code_dir in sagemaker-core so repack dependencies are copied directly into the code root rather than code/lib, matching source-directory packaging and the behavior described in issue #3491 (Source: #3491). The change is minimal and correct: copytree targets code_dir/basename for directories and copy2 targets code_dir for files, preserving the existing collision semantics. New tests cover directory deps, file deps, source-dir coexistence, directory collision, and file overwrite. I found no correctness or test gaps; the PR looks clean.
Reviewed commit 7abcaad. Automated review; verify before acting.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repacked models currently place user dependencies under
code/lib, while SageMaker inference toolkits add onlycodeto the Python path. This change copies file and directory dependencies directly intocode, matching source-directory packaging and making the dependencies importable at runtime.The existing collision behavior is preserved: directory conflicts raise
FileExistsError, while file dependencies retainshutil.copy2overwrite semantics.Testing
git diff --checkpassed.sagemaker-corewheel and source distribution successfully.Related change
The companion V2 fix is published #6461 .
Fixes #3491