fix(train): Enforce Nova Restricted storage on all MTRL MPG branches - #6186
Open
SifeiLi wants to merge 1 commit into
Open
fix(train): Enforce Nova Restricted storage on all MTRL MPG branches#6186SifeiLi wants to merge 1 commit into
SifeiLi wants to merge 1 commit into
Conversation
Restricted managed storage was only applied when MultiTurnRLTrainer auto-created a fresh model package group. The explicit output_model_package_group branch and the continued-customization branch (group derived from the source ModelPackage) performed no Nova check, so a Nova run could silently land its output or intermediate checkpoints in a Standard-storage group, or split lineage across groups depending on the branch taken. Centralize the requirement in _nova_managed_configuration() and apply it on every resolution path for both the output and intermediate checkpoint groups. Existing groups that do not satisfy the requirement now fail fast at trainer construction with an actionable error, since groups cannot be converted after creation. Non-Nova (OSS) models are unaffected. Adds unit tests for the explicit, object, derived, and pre-existing default-named group branches, plus OSS pass-through.
SifeiLi
requested a deployment
to
manual-approval
August 14, 2026 23:04 — with
GitHub Actions
Waiting
SifeiLi
requested a deployment
to
manual-approval
August 14, 2026 23:04 — with
GitHub Actions
Waiting
SifeiLi
requested a deployment
to
manual-approval
August 14, 2026 23:04 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricted managed storage was only applied when MultiTurnRLTrainer auto-created a fresh model package group. The explicit output_model_package_group branch and the continued-customization branch (group derived from the source ModelPackage) performed no Nova check.
Centralize the requirement in _nova_managed_configuration() and apply it on every resolution path for both the output and intermediate checkpoint groups. Existing groups that do not satisfy the requirement now fail fast at trainer construction with an actionable error, since groups cannot be converted after creation. Non-Nova (OSS) models are unaffected.
Adds unit tests for the explicit, object, derived, and pre-existing default-named group branches, plus OSS pass-through.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tested below cases
Integration Tests — Happy Path (real SageMaker, us-east-1, wheel build)
ValueError(bug repro — old SDK proceeded silently)DescribeModelPackageGroupon both auto-created groups returnsManagedStorageType=Restricted(output + intermediate checkpoint)Integration Tests — Deny Cases (real SageMaker, us-east-1, wheel build)
nova-…-mtrl-mpg)ModelPackageGroupobject referencing Standard groupModelPackage(continued customization)Notes: All rejections produce the actionable message "ModelPackageGroup 'X' uses 'Standard' managed storage, but model 'Y' requires 'Restricted'. Existing groups cannot be converted…". Integration runs used the built wheel
(
sagemaker_train-1.20.0) in a clean venv; construction exercised the full real path (live hub metadata fornova-textgeneration-lite-v2, real MPG describe/create, S3 validation). All test fixtures deleted post-run. Non-Nova (OSS)models: no validation, no extra API calls — behavior unchanged.