Skip to content

fix(examples): correct recipe-override precedence asserts in SFT notebook #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hannah14295 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix(examples): correct recipe-override precedence asserts in SFT notebook #6049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions v3-examples/model-customization-examples/recipe_override_sft_trainer_example.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
" overrides={\n",
" \"training_config\": {\n",
" \"learning_rate\": 5e-6, # Override: lower learning rate\n",
" \"num_epochs\": 5 # Override: more epochs\n",
" \"max_steps\": 20 # Override: more steps\n",
" }\n",
" }\n",
")\n",
Expand Down Expand Up @@ -373,7 +373,7 @@
"| Parameter | Recipe File | Override | Resolved (Used) | Source |\n",
"|-----------|------------|----------|-----------------|--------|\n",
"| `learning_rate` | 1e-5 | 5e-6 | **5e-6** | Override wins |\n",
"| `num_epochs` | 3 | 5 | **5** | Override wins |\n",
"| `max_steps` | 10 (default) | 20 | **20** | Override wins |\n",
"| `batch_size` | 8 | (not set) | **8** | Recipe file |\n",
"| `sequence_length` | 2048 | (not set) | **2048** | Recipe file |"
],
Expand All @@ -398,8 +398,8 @@
" print(f\" {key}: {value}\")\n",
"\n",
"# Overrides win over recipe file values\n",
"assert training_config[\"learning_rate\"] == 5e-6, \"Override should win\"\n",
"assert training_config[\"num_epochs\"] == 5, \"Override should win\"\n",
"assert training_config[\"optim_config\"][\"lr\"] == 5e-6, \"Override should win\"\n",
"assert training_config[\"max_steps\"] == 20, \"Override should win\"\n",
"\n",
"print(\"\\nAll precedence checks passed!\")"
],
Expand Down
Loading