-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add numpy 2.0 support #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add numpy 2.0 support #5199
Conversation
Please, PLEASE get this in production ASAP! We are a lot of ML-guys waiting for it :) |
Is it just the few failing integration tests left to fix up? I'd offer to help fix them but it's a little hard to see why they are failing from the output. |
Happy to help if needed. Would love to have numpy 2.x support |
Our ML team also hanging on this! Any required help we can support. |
Hey there, is this PR getting merged soon, seeing that NumPy v1 EoL is approaching in a month (https://endoflife.date/numpy)? |
If someone can digest/understand where it the last unittest fails, then i'm certain that a lot of people would be able (and want) to help fixing that. But it is a bit difficult to see what the issue is tbh |
Issue #, if available:
#4882
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.