Skip to content

Allow import failure for internal _hashlib module #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

WillChilds-Klein
Copy link
Collaborator

@WillChilds-Klein WillChilds-Klein commented Jun 3, 2025

Issue #, if available:

n/a

Description of changes:

This change allows the import of _hashlib to fail. _hashlib is a python-internal module (i.e. it is not meant to be used by applications). It is not present in some build configurations of CPython 3.9, so without this PR the sagemaker SDK cannot be loaded in those runtimes. _hashlib.HASH is only used for type annotations in this library, so conditionally relaxing type constraints on import failure should have no bearing on runtime behavior.

Testing done:

  • internal testing in a brazil workspace, please ping me for details
  • existing GitHub CI

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review June 4, 2025 19:51
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner June 4, 2025 19:51
@Aditi2424 Aditi2424 merged commit 5198f28 into aws:master Jun 6, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants