Skip to content

Add cert mgr installation which is required by HPTO #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emeraldbay
Copy link
Collaborator

@emeraldbay emeraldbay commented Aug 4, 2025

Description

Add latest cert-mgr to the helm chart, which is required by https://docs.aws.amazon.com/sagemaker/latest/dg/sagemaker-eks-operator.html. We want HPTO installed by default, so we also need to install cert mgr by default.

Install the cert mgr under cert-mgr namespace

Testing

helm install dependencies helm_chart/HyperPodHelmChart --namespace kube-system

NAME: dependencies
LAST DEPLOYED: Sun Aug  3 22:51:06 2025
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
TEST SUITE: None

❯ kubectl get pods --namespace cert-manager
NAME                                                  READY   STATUS    RESTARTS   AGE
dependencies-cert-manager-744cf98f4c-clrxp            1/1     Running   0          4m19s
dependencies-cert-manager-cainjector-c59886c7-hqg2s   1/1     Running   0          4m19s
dependencies-cert-manager-webhook-d565d68d9-bmx8t     1/1     Running   0          4m19s

PR Approval Steps

For Requester

  1. Description
    • Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
    • Ensure that the PR follows the contribution guidelines, if applicable.
  2. Security requirements
    • Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
    • Ensure commit has GitHub Commit Signature
  3. Manual review
    1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
      • Code Quality: Check for coding standards, naming conventions, and readability.
      • Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
      • Security: Check for any security issues or vulnerabilities.
      • Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
  4. Check for Merge Conflicts:
    • Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

  1. Go through For Requester section to double check each item.
  2. Request Changes or Approve the PR:
    1. If the PR is ready to be merged, click Review changes and select Approve.
    2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
  3. Merging the PR
    1. Check the Merge Method:
      1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
    2. Merge the PR:
      1. Click the Merge pull request button.
      2. Confirm the merge by clicking Confirm merge.

@emeraldbay emeraldbay requested a review from a team as a code owner August 4, 2025 00:16
@emeraldbay
Copy link
Collaborator Author

jam-jee pushed a commit that referenced this pull request Aug 13, 2025
* Add labels to top level metadata v1.1

* Move topology labels to annotations

* Update topology parameter names

* Add unit test

* Topology integ tests

* Add invalid test case

* Add empty test case

---------

Co-authored-by: pintaoz <[email protected]>
jam-jee added a commit that referenced this pull request Aug 14, 2025
* Add labels to the top level metadata (#158)

Co-authored-by: pintaoz <[email protected]>

* Implemented GPU Quota Allocation Feature.

Co-authored-by: aleszewi <[email protected]>

* Revert "Implemented GPU Quota Allocation Feature."

This reverts commit 790b8f1df59494a982463aaed9e5b3f2afa44123.

* Fix: Template issue - pick user defined template version (#154)

* Fix: Template issue - pick user defined template version

* Fix: Template issue - pick user defined template version & add topology labels in 1.1

* Fix: Template issue - pick user defined template version & add topology labels in 1.1

---------

Co-authored-by: Roja Reddy Sareddy <[email protected]>

* Fix: Add __init__ to the new schema (#163)

* Fix: Template issue - pick user defined template version

* Fix: Template issue - pick user defined template version & add topology labels in 1.1

* Fix: Template issue - pick user defined template version & add topology labels in 1.1

* Fix: Add __init__ to load the new schema

---------

Co-authored-by: Roja Reddy Sareddy <[email protected]>

* Add labels and annotations to top level metadata v1.1 (#165)

* Add labels to top level metadata v1.1

* Move topology labels to annotations

* Update topology parameter names

* Add unit test

---------

Co-authored-by: pintaoz <[email protected]>

* Added GPU quota allocation.

Co-authored-by: aleszewi <[email protected]>

* Changed neuron key to neurondevice. (#177)

Co-authored-by: Marta Aleszewicz <[email protected]>

* fix: Renamed memory-in-gib to memory for consistency. (#179)

cr: https://code.amazon.com/reviews/CR-214599587

Co-authored-by: Marta Aleszewicz <[email protected]>

* Add validation to topology labels (#178)

* Add validation to topology labels

* Add validation to topology labels

* Add validation to topology labels

---------

Co-authored-by: Roja Reddy Sareddy <[email protected]>

* Add integ tests for topology annotations (#180)

* Add labels to top level metadata v1.1

* Move topology labels to annotations

* Update topology parameter names

* Add unit test

* Topology integ tests

* Add invalid test case

* Add empty test case

---------

Co-authored-by: pintaoz <[email protected]>

* Add integration tests for gpu quota allocation feature (#184)

* add integration tests for gpu quota allocation feature

* add valueError assertions for invalid test cases

* Updating the CHANGELOG and minor version

---------

Co-authored-by: pintaoz-aws <[email protected]>
Co-authored-by: pintaoz <[email protected]>
Co-authored-by: Marta Aleszewicz <[email protected]>
Co-authored-by: rsareddy0329 <[email protected]>
Co-authored-by: Roja Reddy Sareddy <[email protected]>
Co-authored-by: mx26pol <[email protected]>
Co-authored-by: satish Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants