fix: send a defaultConfig flag to prevent init with default config #2464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2462) Co-authored-by: Conor Stewart <[email protected]> Co-authored-by: constewart9 <[email protected]> Co-authored-by: manodnyab <[email protected]>
XiaoxuanLu
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2464 +/- ##
==========================================
+ Coverage 62.71% 63.00% +0.28%
==========================================
Files 266 266
Lines 59697 59707 +10
Branches 3840 3865 +25
==========================================
+ Hits 37441 37620 +179
+ Misses 22180 22011 -169
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manodnyab
approved these changes
Nov 7, 2025
shruti0085
reviewed
Nov 7, 2025
| const updateConfigurationHandler = async (updatedConfig: AmazonQWorkspaceConfig) => { | ||
| logging.log('Updating configuration of local context server') | ||
| try { | ||
| if (updatedConfig.isDefaultConfig === true) { |
Contributor
There was a problem hiding this comment.
please add tests for this use case
| logging.log('Updating configuration of local context server') | ||
| try { | ||
| if (updatedConfig.isDefaultConfig === true) { | ||
| logging.log('Skipping init for default config') |
Contributor
There was a problem hiding this comment.
nit: can be a lil more specific
Suggested change
| logging.log('Skipping init for default config') | |
| logging.log('Skipping local project context initialization for default config') |
shruti0085
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the LocalProjectContextController does not respect real config setting for indexing, only the default configuration is called and the real configuration is thrown away if the first call is not finished yet. Thus, the vector indexing won't start and the cache indexing is broken.
Solution
Add a defaultConfig flag to make LocalProjectContextController prevent init with default config and only execute the real config
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.